Merge lp:~lifeless/bzr/test_write_group into lp:~bzr/bzr/trunk-old

Proposed by Robert Collins
Status: Merged
Merged at revision: not available
Proposed branch: lp:~lifeless/bzr/test_write_group
Merge into: lp:~bzr/bzr/trunk-old
Diff against target: 24 lines
To merge this branch: bzr merge lp:~lifeless/bzr/test_write_group
Reviewer Review Type Date Requested Status
Vincent Ladeuil Approve
Review via email: mp+10228@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Robert Collins (lifeless) wrote :

This test wants to check how a repository that has state handles calling
an internal helper function. RemoteRepository proxies all these
requests, so is not able to be tested. The guard on the test was
excluding RemoteRepository earlier, because the default format wasn't
capable of doing external references.

--

Revision history for this message
Vincent Ladeuil (vila) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'bzrlib/tests/per_repository/test_write_group.py'
--- bzrlib/tests/per_repository/test_write_group.py 2009-06-26 09:24:34 +0000
+++ bzrlib/tests/per_repository/test_write_group.py 2009-08-17 04:35:10 +0000
@@ -131,6 +131,7 @@
131 # suppressed. See also test_pack_repository's test of the same name.131 # suppressed. See also test_pack_repository's test of the same name.
132 self.assertEqual(None, repo.abort_write_group(suppress_errors=True))132 self.assertEqual(None, repo.abort_write_group(suppress_errors=True))
133133
134
134class TestGetMissingParentInventories(TestCaseWithRepository):135class TestGetMissingParentInventories(TestCaseWithRepository):
135136
136 def test_empty_get_missing_parent_inventories(self):137 def test_empty_get_missing_parent_inventories(self):
@@ -332,8 +333,10 @@
332333
333 def test_insert_stream_passes_resume_info(self):334 def test_insert_stream_passes_resume_info(self):
334 repo = self.make_repository('test-repo')335 repo = self.make_repository('test-repo')
335 if not repo._format.supports_external_lookups:336 if (not repo._format.supports_external_lookups or
336 raise TestNotApplicable('only valid in resumable repos')337 isinstance(repo, remote.RemoteRepository)):
338 raise TestNotApplicable(
339 'only valid for direct connections to resumable repos')
337 # log calls to get_missing_parent_inventories, so that we can assert it340 # log calls to get_missing_parent_inventories, so that we can assert it
338 # is called with the correct parameters341 # is called with the correct parameters
339 call_log = []342 call_log = []