Code review comment for lp:~lifeless/bzr/test-speed

> This branch:
> * Use copy, not deepcopy, to clone tests in test parameterisation.
> * Make tests for finish_bzr_subprocess that really only care about the
> interface use StubProcess.
> * Remove duplicated test_start_and_stop_working_dir test.
> * Remove unnecessary use of an SFTP server connection to test the
> behaviour of TestCase.make_branch_and_tree.
> * Refactor test_suite to make stubbing out the list of tests to load
> possible without sacrificing coverage.
>

Cough, that's two or three submissions crammed into one, here.

I approve them all, but yet.

I think the copy usage is fine, setUp() is really the test constructor so nothing occurring before that should have an impact on a test.

That may be worth adding a comment though.

You may want to check if your subprocess modifications (removing some bzr --version abusive uses) have addressed the bug about running the test suite in a bound branch.