Code review comment for lp:~lifeless/bzr/repo-source

Robert Collins (lifeless) wrote :

On Thu, 2009-05-14 at 08:43 +0000, Martin Pool wrote:
> Review: Needs Fixing
> I'd like the test to have the URL of the bug it relates to, as a
> pointer in case it regresses or people want more information about the
> test.


> It seems plausible to me but it's not obvious why _get_keys should
> omit ghosts. Maybe the docstring for get_keys or
> PendingAncestryResult should say so?

Perhaps; this api is under discussion at the moment, so rather than
muddy the waters, we'll just make it clearer when we reach consensus.


« Back to merge proposal