Code review comment for lp:~lifeless/bzr/knit-tests

On Mon, 2009-08-17 at 13:33 +0000, John A Meinel wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Robert Collins wrote:
> > Robert Collins has proposed merging lp:~lifeless/bzr/knit-tests into lp:bzr.
> >
> > Requested reviews:
> > bzr-core (bzr-core)
> >
> > [MERGE] Lock the format knit retry tests depend on - knits aren't used
> > for 2a formats.
> >
> >
>
> But we *should* retry the fetches for Groupcompress formats. I don't
> know the specific test here, though.

GCVF doesn't inherit from KVF, though it does the use DirectPackAccess
object directly too.

The test that is failing is currently knit-pack specific, locking it
neither reduces or expands test coverage : if we have a hole its
preserved.

-Rob