Code review comment for lp:~lifeless/bzr-git/bug-526133

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

Jelmer Vernooij wrote:
> On Tue, 2010-02-23 at 07:27 +0000, Robert Collins wrote:
>> Robert Collins has proposed merging lp:~lifeless/bzr-git/bug-526133 into lp:bzr-git.
>>
>> Requested reviews:
>> Michael Hudson (mwhudson)
>> Bazaar Developers (bzr)
>> Related bugs:
>> #526133 need to be able to unload bzr-git
>> https://bugs.launchpad.net/bugs/526133
>>
>>
>> as per request - a [hackish] but function deregister. I made register() so that it can be done again, and to group up the registration activities.
> I wonder, since this is hackish and specific to Launchpad, should it
> perhaps land in lp:~launchpad-pqm/bzr-git/devel ?

I tested the hack in ec2 and it seems sufficient for Launchpad's needs.

Cheers,
mwh

« Back to merge proposal