Code review comment for lp:~lifeless/bzr-builddeb/2.0

Hi,

Thanks for working on this, but merging this gives an empty diff
from my current tree for a few reasons, so I reject.

The info->note changes were fixed by https://code.edge.launchpad.net/~jelmer/bzr-builddeb/no-trace-info/+merge/12587

50 -import commands
51 import os
52
53 from debian_bundle import deb822
54
55 from bzrlib.trace import mutter
56
57 +from bzrlib.plugins.builddeb import commands
58 from bzrlib.plugins.builddeb.errors import DebianError, MissingChanges

There's no bzrlib.plugins.builddeb.commands, and the stdlib
commands module is what is being used, so I think this shouldn't
change.

167 - db.upstream_tag_name(last_version)))
168 + db.upstream_tag_name(str(last_version))))

That's not right, the API doesn't let us distinguish the two types of
version very well, but I had already fixed this properly (last_version.upstream_version)
in a recent revision.

170 - last_version)
171 + last_version.upstream_version)

That had also been fixed in a recent revision.

Thanks,

James