Merge lp:~libqtelegram-team/telegram-app/the-account-name-in-the-top-of-the-dialog-page-is-too-small into lp:telegram-app

Proposed by Jin
Status: Merged
Approved by: Roberto Mier Escandon
Approved revision: 192
Merged at revision: 192
Proposed branch: lp:~libqtelegram-team/telegram-app/the-account-name-in-the-top-of-the-dialog-page-is-too-small
Merge into: lp:telegram-app
Diff against target: 65 lines (+24/-17)
1 file modified
telegram/app/qml/AccountDialogPage.qml (+24/-17)
To merge this branch: bzr merge lp:~libqtelegram-team/telegram-app/the-account-name-in-the-top-of-the-dialog-page-is-too-small
Reviewer Review Type Date Requested Status
Paz Chauhan Approve
Ash Approve
Roberto Mier Escandon (community) Approve
Review via email: mp+294946@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Roberto Mier Escandon (rmescandon) wrote :

Works as expected. LGTM

review: Approve
Revision history for this message
Jin (jindallo) wrote :

@Roberto,

Thanks for your approval!

Revision history for this message
Ash (ashley-richards) wrote :

Tested and I see no defects.

review: Approve
Revision history for this message
Paz Chauhan (paz-chauhan) :
review: Approve
Revision history for this message
Jin (jindallo) wrote :

@Ash
Thanks for your test and review!

@Paz
Many thanks for the approval!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'telegram/app/qml/AccountDialogPage.qml'
--- telegram/app/qml/AccountDialogPage.qml 2016-05-15 13:26:31 +0000
+++ telegram/app/qml/AccountDialogPage.qml 2016-05-17 17:56:40 +0000
@@ -94,7 +94,8 @@
9494
95 flickable: null95 flickable: null
9696
97 head.contents: Rectangle { //Adds components to the header97 //Adds components to the header
98 head.contents: Rectangle {
98 anchors {99 anchors {
99 top: parent.top100 top: parent.top
100 topMargin: units.dp(8)101 topMargin: units.dp(8)
@@ -105,7 +106,8 @@
105 bottom: parent.bottom106 bottom: parent.bottom
106 }107 }
107108
108 Text { //Text adjusts to the parent109 //Text adjusts to the parent
110 Text {
109 anchors {111 anchors {
110 top: parent.top112 top: parent.top
111 topMargin: units.gu(0.2)113 topMargin: units.gu(0.2)
@@ -122,21 +124,26 @@
122 return user ? user.firstName + " " + user.lastName : ""; //Shown if a scret chat124 return user ? user.firstName + " " + user.lastName : ""; //Shown if a scret chat
123 }125 }
124 }126 }
125 font.pointSize: 11127 font.pixelSize: FontUtils.sizeToPixels("large")
126 wrapMode: Text.WordWrap //Word wraps text when text is too long for wdith128 //Word wraps text when text is too long for width
127 elide: Text.ElideRight //Enables the elipse to the end of the text129 wrapMode: Text.WordWrap
128 maximumLineCount: 1 //Wraps text to 1 line130 //Enables the elipse to the end of the text
129 }131 elide: Text.ElideRight
130132 //Wraps text to 1 line
131 Avatar { //Avatar component gets avatar for user as specified from 'dialog' parameter133 maximumLineCount: 1
132 id: imgAvatar134 }
133 width: height135
134136 //Avatar component gets avatar for user as specified from 'dialog' parameter
135 telegram: dialog_page.telegramObject137 Avatar {
136 dialog: dialog_page.currentDialog138 id: imgAvatar
137 }139
138140 width: height
139 Image { //'Lock' image that is overlayed ontop of the Avatar conponent141 telegram: dialog_page.telegramObject
142 dialog: dialog_page.currentDialog
143 }
144
145 //'Lock' image that is overlayed ontop of the Avatar conponent
146 Image {
140 anchors {147 anchors {
141 left: imgAvatar.right148 left: imgAvatar.right
142 leftMargin: -width-5149 leftMargin: -width-5

Subscribers

People subscribed via source and target branches

to all changes:
to status/vote changes: