Merge lp:~libqtelegram-team/telegram-app/the-account-name-in-the-top-of-the-dialog-page-is-too-small into lp:telegram-app

Proposed by Jin
Status: Merged
Approved by: Roberto Mier Escandon
Approved revision: 192
Merged at revision: 192
Proposed branch: lp:~libqtelegram-team/telegram-app/the-account-name-in-the-top-of-the-dialog-page-is-too-small
Merge into: lp:telegram-app
Diff against target: 65 lines (+24/-17)
1 file modified
telegram/app/qml/AccountDialogPage.qml (+24/-17)
To merge this branch: bzr merge lp:~libqtelegram-team/telegram-app/the-account-name-in-the-top-of-the-dialog-page-is-too-small
Reviewer Review Type Date Requested Status
Paz Chauhan Approve
Ash Approve
Roberto Mier Escandon (community) Approve
Review via email: mp+294946@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Roberto Mier Escandon (rmescandon) wrote :

Works as expected. LGTM

review: Approve
Revision history for this message
Jin (jindallo) wrote :

@Roberto,

Thanks for your approval!

Revision history for this message
Ash (ashley-richards) wrote :

Tested and I see no defects.

review: Approve
Revision history for this message
Paz Chauhan (paz-chauhan) :
review: Approve
Revision history for this message
Jin (jindallo) wrote :

@Ash
Thanks for your test and review!

@Paz
Many thanks for the approval!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'telegram/app/qml/AccountDialogPage.qml'
2--- telegram/app/qml/AccountDialogPage.qml 2016-05-15 13:26:31 +0000
3+++ telegram/app/qml/AccountDialogPage.qml 2016-05-17 17:56:40 +0000
4@@ -94,7 +94,8 @@
5
6 flickable: null
7
8- head.contents: Rectangle { //Adds components to the header
9+ //Adds components to the header
10+ head.contents: Rectangle {
11 anchors {
12 top: parent.top
13 topMargin: units.dp(8)
14@@ -105,7 +106,8 @@
15 bottom: parent.bottom
16 }
17
18- Text { //Text adjusts to the parent
19+ //Text adjusts to the parent
20+ Text {
21 anchors {
22 top: parent.top
23 topMargin: units.gu(0.2)
24@@ -122,21 +124,26 @@
25 return user ? user.firstName + " " + user.lastName : ""; //Shown if a scret chat
26 }
27 }
28- font.pointSize: 11
29- wrapMode: Text.WordWrap //Word wraps text when text is too long for wdith
30- elide: Text.ElideRight //Enables the elipse to the end of the text
31- maximumLineCount: 1 //Wraps text to 1 line
32- }
33-
34- Avatar { //Avatar component gets avatar for user as specified from 'dialog' parameter
35- id: imgAvatar
36- width: height
37-
38- telegram: dialog_page.telegramObject
39- dialog: dialog_page.currentDialog
40- }
41-
42- Image { //'Lock' image that is overlayed ontop of the Avatar conponent
43+ font.pixelSize: FontUtils.sizeToPixels("large")
44+ //Word wraps text when text is too long for width
45+ wrapMode: Text.WordWrap
46+ //Enables the elipse to the end of the text
47+ elide: Text.ElideRight
48+ //Wraps text to 1 line
49+ maximumLineCount: 1
50+ }
51+
52+ //Avatar component gets avatar for user as specified from 'dialog' parameter
53+ Avatar {
54+ id: imgAvatar
55+
56+ width: height
57+ telegram: dialog_page.telegramObject
58+ dialog: dialog_page.currentDialog
59+ }
60+
61+ //'Lock' image that is overlayed ontop of the Avatar conponent
62+ Image {
63 anchors {
64 left: imgAvatar.right
65 leftMargin: -width-5

Subscribers

People subscribed via source and target branches

to all changes:
to status/vote changes: