Merge lp:~libqtelegram-team/telegram-app/fix-the-ContentPeerPicker-layout-issue into lp:telegram-app

Proposed by Jin
Status: Merged
Approved by: Roberto Mier Escandon
Approved revision: 249
Merged at revision: 248
Proposed branch: lp:~libqtelegram-team/telegram-app/fix-the-ContentPeerPicker-layout-issue
Merge into: lp:telegram-app
Diff against target: 56 lines (+10/-7)
3 files modified
telegram/app/qml/MediaImport.qml (+3/-0)
telegram/app/qml/PickerPage.qml (+4/-7)
telegram/app/qml/components/MediaImport.qml (+3/-0)
To merge this branch: bzr merge lp:~libqtelegram-team/telegram-app/fix-the-ContentPeerPicker-layout-issue
Reviewer Review Type Date Requested Status
Roberto Mier Escandon (community) Approve
Review via email: mp+311133@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Roberto Mier Escandon (rmescandon) wrote :

Not sure what is changing here, but if I try to import a contact from Address Book, the "Choose from" is not on top (this was not happening before)

review: Needs Fixing
249. By Jin

Revert file: ContactImport.qml

Revision history for this message
Jin (jindallo) wrote :

@Roberto,

Thanks man, already fixed and verified on my local,
please have a look on those changes.

Revision history for this message
Roberto Mier Escandon (rmescandon) wrote :

Works as expected

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'telegram/app/qml/MediaImport.qml'
--- telegram/app/qml/MediaImport.qml 2016-04-08 06:08:04 +0000
+++ telegram/app/qml/MediaImport.qml 2016-11-17 14:27:00 +0000
@@ -51,8 +51,11 @@
51 id: peerPicker51 id: peerPicker
5252
53 anchors.fill: parent53 anchors.fill: parent
54 anchors.topMargin: page.header.height
55
54 contentType: root.contentType56 contentType: root.contentType
55 handler: ContentHub.ContentHandler.Source57 handler: ContentHub.ContentHandler.Source
58 showTitle: true
5659
57 onPeerSelected: {60 onPeerSelected: {
58 peer.selectionType = ContentHub.ContentTransfer.Single61 peer.selectionType = ContentHub.ContentTransfer.Single
5962
=== modified file 'telegram/app/qml/PickerPage.qml'
--- telegram/app/qml/PickerPage.qml 2016-09-05 07:47:08 +0000
+++ telegram/app/qml/PickerPage.qml 2016-11-17 14:27:00 +0000
@@ -31,16 +31,13 @@
31 }31 }
3232
33 ContentPeerPicker {33 ContentPeerPicker {
34 anchors {34 anchors.fill: parent
35 top: picker.bottom35 anchors.topMargin: page.header.height
36 left: parent.left36
37 right: parent.right
38 margins: units.gu(6)
39 }
40 visible: parent.visible37 visible: parent.visible
41 contentType: picker.contentType38 contentType: picker.contentType
42 handler: picker.handler39 handler: picker.handler
43 showTitle: false40 showTitle: true
44 onPeerSelected: {41 onPeerSelected: {
45 picker.curTransfer = peer.request();42 picker.curTransfer = peer.request();
46 pageStack.removePages(picker);43 pageStack.removePages(picker);
4744
=== modified file 'telegram/app/qml/components/MediaImport.qml'
--- telegram/app/qml/components/MediaImport.qml 2016-11-09 10:32:21 +0000
+++ telegram/app/qml/components/MediaImport.qml 2016-11-17 14:27:00 +0000
@@ -53,8 +53,11 @@
53 objectName: "contentPeerPicker"53 objectName: "contentPeerPicker"
5454
55 anchors.fill: parent55 anchors.fill: parent
56 anchors.topMargin: page.header.height
57
56 contentType: root.contentType58 contentType: root.contentType
57 handler: ContentHub.ContentHandler.Source59 handler: ContentHub.ContentHandler.Source
60 showTitle: true
5861
59 onPeerSelected: {62 onPeerSelected: {
60 peer.selectionType = ContentHub.ContentTransfer.Multiple63 peer.selectionType = ContentHub.ContentTransfer.Multiple

Subscribers

People subscribed via source and target branches

to all changes:
to status/vote changes: