Merge lp:~libqtelegram-team/telegram-app/fix-the-ContentPeerPicker-layout-issue into lp:telegram-app

Proposed by Jin
Status: Merged
Approved by: Roberto Mier Escandon
Approved revision: 249
Merged at revision: 248
Proposed branch: lp:~libqtelegram-team/telegram-app/fix-the-ContentPeerPicker-layout-issue
Merge into: lp:telegram-app
Diff against target: 56 lines (+10/-7)
3 files modified
telegram/app/qml/MediaImport.qml (+3/-0)
telegram/app/qml/PickerPage.qml (+4/-7)
telegram/app/qml/components/MediaImport.qml (+3/-0)
To merge this branch: bzr merge lp:~libqtelegram-team/telegram-app/fix-the-ContentPeerPicker-layout-issue
Reviewer Review Type Date Requested Status
Roberto Mier Escandon (community) Approve
Review via email: mp+311133@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Roberto Mier Escandon (rmescandon) wrote :

Not sure what is changing here, but if I try to import a contact from Address Book, the "Choose from" is not on top (this was not happening before)

review: Needs Fixing
249. By Jin

Revert file: ContactImport.qml

Revision history for this message
Jin (jindallo) wrote :

@Roberto,

Thanks man, already fixed and verified on my local,
please have a look on those changes.

Revision history for this message
Roberto Mier Escandon (rmescandon) wrote :

Works as expected

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'telegram/app/qml/MediaImport.qml'
2--- telegram/app/qml/MediaImport.qml 2016-04-08 06:08:04 +0000
3+++ telegram/app/qml/MediaImport.qml 2016-11-17 14:27:00 +0000
4@@ -51,8 +51,11 @@
5 id: peerPicker
6
7 anchors.fill: parent
8+ anchors.topMargin: page.header.height
9+
10 contentType: root.contentType
11 handler: ContentHub.ContentHandler.Source
12+ showTitle: true
13
14 onPeerSelected: {
15 peer.selectionType = ContentHub.ContentTransfer.Single
16
17=== modified file 'telegram/app/qml/PickerPage.qml'
18--- telegram/app/qml/PickerPage.qml 2016-09-05 07:47:08 +0000
19+++ telegram/app/qml/PickerPage.qml 2016-11-17 14:27:00 +0000
20@@ -31,16 +31,13 @@
21 }
22
23 ContentPeerPicker {
24- anchors {
25- top: picker.bottom
26- left: parent.left
27- right: parent.right
28- margins: units.gu(6)
29- }
30+ anchors.fill: parent
31+ anchors.topMargin: page.header.height
32+
33 visible: parent.visible
34 contentType: picker.contentType
35 handler: picker.handler
36- showTitle: false
37+ showTitle: true
38 onPeerSelected: {
39 picker.curTransfer = peer.request();
40 pageStack.removePages(picker);
41
42=== modified file 'telegram/app/qml/components/MediaImport.qml'
43--- telegram/app/qml/components/MediaImport.qml 2016-11-09 10:32:21 +0000
44+++ telegram/app/qml/components/MediaImport.qml 2016-11-17 14:27:00 +0000
45@@ -53,8 +53,11 @@
46 objectName: "contentPeerPicker"
47
48 anchors.fill: parent
49+ anchors.topMargin: page.header.height
50+
51 contentType: root.contentType
52 handler: ContentHub.ContentHandler.Source
53+ showTitle: true
54
55 onPeerSelected: {
56 peer.selectionType = ContentHub.ContentTransfer.Multiple

Subscribers

People subscribed via source and target branches

to all changes:
to status/vote changes: