Merge ~liaou3/checkbox-limerick/+git/checkbox-provider-limerick:add_usb_wake_from_keyboard into ~checkbox-dev/checkbox-limerick/+git/checkbox-provider-limerick:master

Proposed by Vincent Liao
Status: Merged
Approved by: Vincent Liao
Approved revision: dd5fa5584674a7eb2b1a3b8a541e73958308597a
Merged at revision: 749424a987f91f8afe0f7b97e0b9ed36b0613386
Proposed branch: ~liaou3/checkbox-limerick/+git/checkbox-provider-limerick:add_usb_wake_from_keyboard
Merge into: ~checkbox-dev/checkbox-limerick/+git/checkbox-provider-limerick:master
Diff against target: 72 lines (+32/-0)
5 files modified
units/kr260-test-plan-classic.pxu (+1/-0)
units/kv260-test-plan-classic.pxu (+1/-0)
units/usb/category.pxu (+3/-0)
units/usb/jobs.pxu (+21/-0)
units/usb/test-plan.pxu (+6/-0)
Reviewer Review Type Date Requested Status
StanleyHuang Approve
PeiYao Chang Approve
Rick Wu Pending
Vic Liu Pending
Weichen Wu Pending
Review via email: mp+463099@code.launchpad.net

Commit message

Add wake from usb keyboard tests

Description of the change

To cover this LP#2057466, we add test to cover wake from usb keyboard.

Submission: https://certification.canonical.com/hardware/202202-29984/submission/361959/

To post a comment you must log in.
Revision history for this message
PeiYao Chang (baconyao) wrote :

See my inline comment

review: Needs Information
Revision history for this message
PeiYao Chang (baconyao) wrote :

+1

review: Approve
Revision history for this message
StanleyHuang (stanley31) :
review: Needs Information
Revision history for this message
Vincent Liao (liaou3) wrote :

Answered

Revision history for this message
StanleyHuang (stanley31) wrote :

Thanks for the answer, LGTM.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/units/kr260-test-plan-classic.pxu b/units/kr260-test-plan-classic.pxu
index f6e21d2..548e239 100644
--- a/units/kr260-test-plan-classic.pxu
+++ b/units/kr260-test-plan-classic.pxu
@@ -32,6 +32,7 @@ nested_part:
32 com.canonical.certification::client-cert-iot-server-22-04-manual32 com.canonical.certification::client-cert-iot-server-22-04-manual
33 limerick-after-suspend-monitor-manual33 limerick-after-suspend-monitor-manual
34 com.canonical.certification::after-suspend-graphics-integrated-gpu-cert-manual34 com.canonical.certification::after-suspend-graphics-integrated-gpu-cert-manual
35 limerick-usb-manual
35exclude:36exclude:
36 com.canonical.certification::audio.* # keep if audio is not supported37 com.canonical.certification::audio.* # keep if audio is not supported
37 com.canonical.certification::bluetooth.* # keep if bluetooth is not supported38 com.canonical.certification::bluetooth.* # keep if bluetooth is not supported
diff --git a/units/kv260-test-plan-classic.pxu b/units/kv260-test-plan-classic.pxu
index b343bf9..cf58bba 100644
--- a/units/kv260-test-plan-classic.pxu
+++ b/units/kv260-test-plan-classic.pxu
@@ -42,6 +42,7 @@ nested_part:
42 com.canonical.certification::client-cert-iot-server-22-04-manual42 com.canonical.certification::client-cert-iot-server-22-04-manual
43 limerick-after-suspend-monitor-manual43 limerick-after-suspend-monitor-manual
44 com.canonical.certification::after-suspend-graphics-integrated-gpu-cert-manual44 com.canonical.certification::after-suspend-graphics-integrated-gpu-cert-manual
45 limerick-usb-manual
45exclude:46exclude:
46 com.canonical.certification::audio.* # keep if audio is not supported47 com.canonical.certification::audio.* # keep if audio is not supported
47 com.canonical.certification::bluetooth.* # keep if bluetooth is not supported48 com.canonical.certification::bluetooth.* # keep if bluetooth is not supported
diff --git a/units/usb/category.pxu b/units/usb/category.pxu
48new file mode 10064449new file mode 100644
index 0000000..b92a601
--- /dev/null
+++ b/units/usb/category.pxu
@@ -0,0 +1,3 @@
1unit: category
2id: limerick-usb
3_name: Limerick USB Test
diff --git a/units/usb/jobs.pxu b/units/usb/jobs.pxu
0new file mode 1006444new file mode 100644
index 0000000..32dde2b
--- /dev/null
+++ b/units/usb/jobs.pxu
@@ -0,0 +1,21 @@
1unit: job
2plugin: user-interact-verify
3id: limerick-usb/wake-on-usb-keyboard
4category_id: limerick-usb
5user: root
6estimated_duration: 1m
7_summary: Wake system up from suspend with usb keyboard
8command:
9 wakeup_sources=$(find /sys/ | grep /power/wakeup\$ | grep usb)
10 for device in $wakeup_sources; do
11 echo enabled > "$device"
12 done
13 systemctl suspend
14_purpose:
15 To test if the system could wake up from suspend with usb keyboard
16_steps:
17 1. Press enter to enter suspend.
18 2. Wait for 10 seconds.
19 3. Press 'Enter' to wake system up.
20_verification:
21 Does the system resume from suspend successfully?
diff --git a/units/usb/test-plan.pxu b/units/usb/test-plan.pxu
0new file mode 10064422new file mode 100644
index 0000000..e39a00b
--- /dev/null
+++ b/units/usb/test-plan.pxu
@@ -0,0 +1,6 @@
1id: limerick-usb-manual
2unit: test plan
3_name: Limerick Manual USB Tests
4_description: Manual USB test for Limerick
5include:
6 limerick-usb/wake-on-usb-keyboard

Subscribers

People subscribed via source and target branches