Calculator

Merge lp:~lexsurkov/pantheon-calculator/Bug_1409485 into lp:~elementary-apps/pantheon-calculator/trunk

  1. Bug_1409485
  2. Merge into trunk
Proposed by lexsurkov
Status: Superseded
Proposed branch: lp:~lexsurkov/pantheon-calculator/Bug_1409485
Merge into: lp:~elementary-apps/pantheon-calculator/trunk
Diff against target: 0 lines
To merge this branch: bzr merge lp:~lexsurkov/pantheon-calculator/Bug_1409485
Reviewer Review Type Date Requested Status
xapantu Pending
kay van der Zander Pending
Review via email: mp+271512@code.launchpad.net

This proposal supersedes a proposal from 2015-09-15.

This proposal has been superseded by a proposal from 2015-09-19.

Commit message

Fixed Bug_1409485

Description of the change

Fixed Bug_1409485

To post a comment you must log in.
Revision history for this message
xapantu (xapantu) wrote : Posted in a previous version of this proposal

It looks like you forgot to commit your changes, this branch is the same as the trunk.

review: Needs Information
Revision history for this message
xapantu (xapantu) wrote : Posted in a previous version of this proposal

Hum, listening to the event signal directly is not needed. Maybe you can just move your code to the key_pressed method?

review: Needs Fixing
Revision history for this message
lexsurkov (lexsurkov) wrote : Posted in a previous version of this proposal

Thank you, hastened to, not tested in the method key_pressed. In the future, I will carefully)))
Now I corrected.
.

> 15.09.2015, 2:18:25 пользователь xapantu (<email address hidden>) написал:
>
> Review: Needs Fixing
>
> Hum, listening to the event signal directly is not needed. Maybe you can just move your code to the key_pressed method?
> --
> https://code.launchpad.net/~lexsurkov/pantheon-calculator/Bug_1409485/+merge/269764
> You are the owner of lp:~lexsurkov/pantheon-calculator/Bug_1409485.
>
>

Revision history for this message
kay van der Zander (kay20) wrote : Posted in a previous version of this proposal

the targeted bug is still not fixed in this branch.

http://imgur.com/H84xfbB you see there is still possible to get the wrong representation of multiply and devide.

http://imgur.com/YHRZjaw the red keys give the wrong representation the green keys work.

review: Needs Fixing
Revision history for this message
lexsurkov (lexsurkov) wrote :

Invalid the commit wrote. Added support 'RED' the keys.

Revision history for this message
kay van der Zander (kay20) wrote :

what you could do before i test it again. is to keep your commit to one revision.
use uncommit command to change a commit. by unmerged versions here below there should be only one unmerged commit revision 160.

Revision history for this message
lexsurkov (lexsurkov) wrote :

The first time I use with SVN. Now the code is correct but the changes do not appear. Maybe lift up a new branch?

Revision history for this message
Rico Tzschichholz (ricotz) wrote :

@lexsurkov: Simply using the "Resubmit proposal" option should get this straight again.

But please use a *sane* commit message which is actually describes what you did, instead of this abstract "Fixed bug XXXX".

lp:~lexsurkov/pantheon-calculator/Bug_1409485 updated
160. By lexsurkov

Fixed inconsistent GUI and keyboard input

Unmerged revisions

Preview Diff

Empty

Subscribers

People subscribed via source and target branches

to all changes: