Merge lp:~lexsurkov/pantheon-calculator/Bug_1409485 into lp:~elementary-apps/pantheon-calculator/trunk

[lexsurkov]

Fixed inconsistent GUI and keyboard input

Fixed inconsistent GUI and keyboard input

[xapantu (xapantu)]

It looks like you forgot to commit your changes, this branch is the same as the trunk.

review: Needs Information

[xapantu (xapantu)]

Hum, listening to the event signal directly is not needed. Maybe you can just move your code to the key_pressed method?

review: Needs Fixing

[lexsurkov (lexsurkov)]

Thank you, hastened to, not tested in the method key_pressed. In the future, I will carefully)))
Now I corrected.
.

> 15.09.2015, 2:18:25 пользователь xapantu (<email address hidden>) написал:
>
> Review: Needs Fixing
>
> Hum, listening to the event signal directly is not needed. Maybe you can just move your code to the key_pressed method?
> --
> https://code.launchpad.net/~lexsurkov/pantheon-calculator/Bug_1409485/+merge/269764
> You are the owner of lp:~lexsurkov/pantheon-calculator/Bug_1409485.
>
>

[kay van der Zander (kay20)]

the targeted bug is still not fixed in this branch.

http://imgur.com/H84xfbB you see there is still possible to get the wrong representation of multiply and devide.

http://imgur.com/YHRZjaw the red keys give the wrong representation the green keys work.

review: Needs Fixing

[lexsurkov (lexsurkov)]

Invalid the commit wrote. Added support 'RED' the keys.

[kay van der Zander (kay20)]

what you could do before i test it again. is to keep your commit to one revision.
use uncommit command to change a commit. by unmerged versions here below there should be only one unmerged commit revision 160.

[lexsurkov (lexsurkov)]

The first time I use with SVN. Now the code is correct but the changes do not appear. Maybe lift up a new branch?

[Rico Tzschichholz (ricotz)]

@lexsurkov: Simply using the "Resubmit proposal" option should get this straight again.

But please use a *sane* commit message which is actually describes what you did, instead of this abstract "Fixed bug XXXX".

[lexsurkov (lexsurkov)]

Thank you all, I got a great experience. I will continue to work on themselves and on ElementaryOS

[kay van der Zander (kay20)]

He i have test all keyboards shortcuts for any math related symbols.
I have found one more and that is the symbol '-' see image http://imgur.com/JjOK18H
watch it there are 2 '-' symbols on a international us keyboard.

after this i will approve

review: Needs Fixing

[lp:~lexsurkov/pantheon-calculator/Bug_1409485]

160. By lexsurkov on 2015-09-25

Fixed inconsistent GUI and keyboard input

Unmerged revisions