Code review comment for lp:~leonardr/wadllib/convert-datetime-309950

Revision history for this message
Edwin Grubbs (edwin-grubbs) wrote :

Leonard,

I think that Gary makes some very good points, and I would like to know if you disagree with any of the changes he suggests. I only see one other typo. Since this branch does not have a review requested from the ~launchpad team, I'm unable to vote on this merge-proposal.

> === modified file 'wadllib/docs/wadllib.txt'
> --- wadllib/docs/wadllib.txt 2008-08-11 17:56:11 +0000
> +++ wadllib/docs/wadllib.txt 2009-01-21 19:58:38 +0000
> @@ -116,8 +116,8 @@
> test data.
>
> >>> bound_service_root = bind_to_testdata(service_root, 'root')
> - >>> bound_service_root.parameter_names()
> - ['people_collection_link', 'bugs_collection_link']
> + >>> sorted(bound_service_root.parameter_names())
> + ['bugs_collection_link', 'people_collection_link']
> >>> [method.id for method in bound_service_root.method_iter]
> ['service-root-get']
>
> @@ -266,7 +266,8 @@
>
> >>> bound_limi = bind_to_testdata(limi_person, 'person-limi')
> >>> sorted(bound_limi.parameter_names())[:3]
> - ['admins_collection_link', 'confirmed_email_addresses_collection_link', 'date_created']
> + ['admins_collection_link', 'confirmed_email_addresses_collection_link',
> + 'date_created']
> >>> languages_link = bound_limi.get_parameter("languages_collection_link")
> >>> languages_link.get_value()
> u'http://api.launchpad.dev/beta/~limi/languages'
> @@ -302,7 +303,7 @@
> an example.
>
> There's a method on a person resource such as bound_limi that's
> -identified by a distinctive query argument: ws.op=findPathToTeam.
> +identified by a distinctive query argument: ws.op=getMembersByStatus.
>
> >>> method = bound_limi.get_method(
> ... query_params={'ws.op' : 'findPathToTeam'})
> @@ -353,6 +354,51 @@
> >>> print method.response.get_representation_definition('text/html')
> None
>
> +=== Data type converstion ===

s/converstion/conversion/

« Back to merge proposal