Code review comment for lp:~leonardr/wadllib/convert-datetime-309950

Revision history for this message
Leonard Richardson (leonardr) wrote :

This is the first wadllib branch in quite a while. It gives wadllib
knowledge about parameters with a type of "xsd:date" or
"xsd:dateTime". It will automatically serialize the values of such
parameters to Python datetime objects.

It would be nice if it could use the current document's XSD namespace
instead of assuming "xsd", but it's not necessary for our purposes and
it seems like a fair amount of work. Let me know what you think.

I'm not sure why a number of these changes (especially the licensing
stuff) aren't already in the repository, but they show up in the diff
against LP trunk, and they're not hard to review.

This branch includes iso_strptime.py, a file contributed by Markus
Korn. We are still waiting for Amanda to come back with rules for
accepting outside contributions, so this branch can't actually land
until we figure out whether, eg. we need Markus to sign a copyright
release.

To test this branch, check out a Launchpad branch, set it up, and then
change its sourcecode/wadllib to point to the wadllib branch. Or you
can run nose on the wadllib branch if you can remember the syntax. I
find it easier to just do it through Launchpad.

I expected this test to cause launchpadlib tests to fail, but I didn't
expect the specific failures I got. Let me know what failures you get
and we'll figure it out.

« Back to merge proposal