Code review comment for lp:~leonardr/lazr.restful/make-test-class-public

Hi Leonard,

The changes look good, but I got these errors when running the tests under python2.6. There were even more problems under python2.5.

-Edwin

Running lazr.restful.example.base.tests.test_integration.WSGILayer tests:
  Set up lazr.restful.example.base.tests.test_integration.FunctionalLayer in 0.328 seconds.
  Set up lazr.restful.example.base.tests.test_integration.WSGILayer in 0.000 seconds.

Failure in test /home/egrubbs/canonical/launchpadlib/refactor-tag-request-with-version/src/lazr/restful/example/base/tests/field.txt
Traceback (most recent call last):
  File "/usr/lib/python2.5/unittest.py", line 260, in run
    testMethod()
  File "/usr/lib/python2.5/doctest.py", line 2128, in runTest
    raise self.failureException(self.format_failure(new.getvalue()))
AssertionError: Failed doctest test for field.txt
  File "/home/egrubbs/canonical/launchpadlib/refactor-tag-request-with-version/src/lazr/restful/example/base/tests/field.txt", line 0

----------------------------------------------------------------------
File "/home/egrubbs/canonical/launchpadlib/refactor-tag-request-with-version/src/lazr/restful/example/base/tests/field.txt", line 55, in field.txt
Failed example:
    print new_value
Differences (ndiff with -expected +actual):
    - "http://.../cookbooks/The%20Joy%20of%20Cooking"
    ? ^^^^
    + "http:\/\/cookbooks.dev\/devel\/cookbooks\/The%20Joy%20of%20Cooking"
    ? + ^ +++++++++++++++++++++++
----------------------------------------------------------------------
File "/home/egrubbs/canonical/launchpadlib/refactor-tag-request-with-version/src/lazr/restful/example/base/tests/field.txt", line 58, in field.txt
Failed example:
    print webservice(link_field_url, 'PATCH', new_value)
Differences (ndiff with -expected +actual):
      HTTP/1.1 209 Content Returned
    - ...
    + Status: 209 Content Returned
    + Content-Length: 68
      Content-Type: application/json
    - ...
    + X-Powered-By: Zope (www.zope.org), Python (www.python.org)
      <BLANKLINE>
    - "http://cookbooks.dev/.../cookbooks/The%20Joy%20of%20Cooking"
    ? ^^^
    + "http:\/\/cookbooks.dev\/devel\/cookbooks\/The%20Joy%20of%20Cooking"
    ? + + + ^^^^^^ +

  Ran 9 tests with 1 failures and 0 errors in 2.391 seconds.
Running lazr.restful.example.multiversion.tests.test_integration.WSGILayer tests:
  Tear down lazr.restful.example.base.tests.test_integration.WSGILayer in 0.000 seconds.
  Tear down lazr.restful.example.base.tests.test_integration.FunctionalLayer in 0.000 seconds.
  Set up lazr.restful.example.multiversion.tests.test_integration.FunctionalLayer in 0.078 seconds.
  Set up lazr.restful.example.multiversion.tests.test_integration.WSGILayer in 0.000 seconds.
  Ran 3 tests with 0 failures and 0 errors in 0.406 seconds.
Running lazr.restful.example.wsgi.tests.test_integration.WSGILayer tests:
  Tear down lazr.restful.example.multiversion.tests.test_integration.WSGILayer in 0.001 seconds.
  Tear down lazr.restful.example.multiversion.tests.test_integration.FunctionalLayer in 0.000 seconds.
  Set up lazr.restful.example.wsgi.tests.test_integration.FunctionalLayer in 0.069 seconds.
  Set up lazr.restful.example.wsgi.tests.test_integration.WSGILayer in 0.000 seconds.
  Ran 1 tests with 0 failures and 0 errors in 0.010 seconds.
Running zope.testing.testrunner.layer.UnitTests tests:
  Tear down lazr.restful.example.wsgi.tests.test_integration.WSGILayer in 0.000 seconds.
  Tear down lazr.restful.example.wsgi.tests.test_integration.FunctionalLayer in 0.000 seconds.
  Set up zope.testing.testrunner.layer.UnitTests in 0.000 seconds.

Failure in test /home/egrubbs/canonical/launchpadlib/refactor-tag-request-with-version/src/lazr/restful/docs/multiversion.txt
Traceback (most recent call last):
  File "/usr/lib/python2.5/unittest.py", line 260, in run
    testMethod()
  File "/usr/lib/python2.5/doctest.py", line 2128, in runTest
    raise self.failureException(self.format_failure(new.getvalue()))
AssertionError: Failed doctest test for multiversion.txt
  File "/home/egrubbs/canonical/launchpadlib/refactor-tag-request-with-version/src/lazr/restful/docs/multiversion.txt", line 0

----------------------------------------------------------------------
File "/home/egrubbs/canonical/launchpadlib/refactor-tag-request-with-version/src/lazr/restful/docs/multiversion.txt", line 647, in multiversion.txt
Failed example:
    print sorted(body.keys())
Differences (ndiff with -expected +actual):
    - ['contacts_collection_link', 'resource_type_link']
    + [u'contacts_collection_link', u'resource_type_link']
    ? + +
----------------------------------------------------------------------
File "/home/egrubbs/canonical/launchpadlib/refactor-tag-request-with-version/src/lazr/restful/docs/multiversion.txt", line 692, in multiversion.txt
Failed example:
    sorted(body.keys())
Differences (ndiff with -expected +actual):
    - ['fax', 'http_etag', 'name', 'phone', 'resource_type_link', 'self_link']
    + [u'fax', u'http_etag', u'name', u'phone', u'resource_type_link', u'self_link']
    ? + + + + + +
----------------------------------------------------------------------
File "/home/egrubbs/canonical/launchpadlib/refactor-tag-request-with-version/src/lazr/restful/docs/multiversion.txt", line 713, in multiversion.txt
Failed example:
    [contact['name'] for contact in result['entries']]
Differences (ndiff with -expected +actual):
    - ['Cleo Python']
    + [u'Cleo Python']
    ? +
----------------------------------------------------------------------
File "/home/egrubbs/canonical/launchpadlib/refactor-tag-request-with-version/src/lazr/restful/docs/multiversion.txt", line 722, in multiversion.txt
Failed example:
    [contact['fax'] for contact in result['entries']]
Differences (ndiff with -expected +actual):
    - ['111-2121']
    + [u'111-2121']
    ? +
----------------------------------------------------------------------
File "/home/egrubbs/canonical/launchpadlib/refactor-tag-request-with-version/src/lazr/restful/docs/multiversion.txt", line 734, in multiversion.txt
Failed example:
    print sorted(body.keys())
Differences (ndiff with -expected +actual):
    - ['contacts_collection_link', 'resource_type_link']
    + [u'contacts_collection_link', u'resource_type_link']
    ? + +
----------------------------------------------------------------------
File "/home/egrubbs/canonical/launchpadlib/refactor-tag-request-with-version/src/lazr/restful/docs/multiversion.txt", line 781, in multiversion.txt
Failed example:
    sorted(body.keys())
Differences (ndiff with -expected +actual):
    + [u'fax_number', u'http_etag', u'name', u'phone_number', u'resource_type_link', u'self_link']
    - ['fax_number', 'http_etag', 'name', 'phone_number',
    - 'resource_type_link', 'self_link']
----------------------------------------------------------------------
File "/home/egrubbs/canonical/launchpadlib/refactor-tag-request-with-version/src/lazr/restful/docs/multiversion.txt", line 813, in multiversion.txt
Failed example:
    [contact['name'] for contact in result['entries']]
Differences (ndiff with -expected +actual):
    - ['Cleo Python']
    + [u'Cleo Python']
    ? +
----------------------------------------------------------------------
File "/home/egrubbs/canonical/launchpadlib/refactor-tag-request-with-version/src/lazr/restful/docs/multiversion.txt", line 821, in multiversion.txt
Failed example:
    [contact['fax_number'] for contact in result['entries']]
Differences (ndiff with -expected +actual):
    - ['111-2121']
    + [u'111-2121']
    ? +
----------------------------------------------------------------------
File "/home/egrubbs/canonical/launchpadlib/refactor-tag-request-with-version/src/lazr/restful/docs/multiversion.txt", line 841, in multiversion.txt
Failed example:
    print sorted(body.keys())
Differences (ndiff with -expected +actual):
    - ['contacts_collection_link', 'resource_type_link']
    + [u'contacts_collection_link', u'resource_type_link']
    ? + +
----------------------------------------------------------------------
File "/home/egrubbs/canonical/launchpadlib/refactor-tag-request-with-version/src/lazr/restful/docs/multiversion.txt", line 876, in multiversion.txt
Failed example:
    sorted(body.keys())
Differences (ndiff with -expected +actual):
    - ['http_etag', 'name', 'phone_number', 'resource_type_link', 'self_link']
    + [u'http_etag', u'name', u'phone_number', u'resource_type_link', u'self_link']
    ? + + + + +
----------------------------------------------------------------------
File "/home/egrubbs/canonical/launchpadlib/refactor-tag-request-with-version/src/lazr/restful/docs/multiversion.txt", line 913, in multiversion.txt
Failed example:
    [contact['name'] for contact in result['entries']]
Differences (ndiff with -expected +actual):
    - ['Cleo Python']
    + [u'Cleo Python']
    ? +

  Ran 29 tests with 1 failures and 0 errors in 1.865 seconds.
Tearing down left over layers:
  Tear down zope.testing.testrunner.layer.UnitTests in 0.000 seconds.
Total: 42 tests, 2 failures, 0 errors in 5.494 seconds.