Code review comment for lp:~leonardr/launchpadlib/trusted-workflow-tests-2

On Fri, 2009-10-30 at 17:29 -0200, Guilherme Salgado wrote:
>
> > + return self.pressEnterToExit()
> > +
> > + def exit_with(self, code):
>
> Why is this not exitWith()?

As you explained to me on IRC, this is because you're using the python
naming standard instead of the LP one. Fair enough, but the two methods
below use the LP one. Care to rename them?

And here's a review of the two remaining files, which had conflicts when
I first reviewed your branch. Just one question, in fact.

> === modified file 'src/launchpadlib/credentials.py'
> --- src/launchpadlib/credentials.py 2009-10-30 14:48:21 +0000
> +++ src/launchpadlib/credentials.py 2009-10-30 19:55:30 +0000
> @@ -289,16 +291,20 @@
>
> def __init__(self, web_root, consumer_name, request_token,
> allow_access_levels=[], max_failed_attempts=3):
> - self.web_root = web_root
> + self.web_root = uris.lookup_web_root(web_root)

What's the reason for this change?

> self.consumer_name = consumer_name
> self.request_token = request_token
> self.browser = SimulatedLaunchpadBrowser(self.web_root)
> self.max_failed_attempts = max_failed_attempts
> self.allow_access_levels = allow_access_levels
> + self.text_wrapper = textwrap.TextWrapper(
> + replace_whitespace=False, width=78)
>