Merge lp:~leonardr/launchpadlib/correct-test-failure into lp:launchpadlib

[Leonard Richardson]

This branch corrects a test failure that doesn't show up locally or on an EC2 instance, but which does break buildbot. In introduction.txt, we call TestLaunchpad.login_anonymously(). TestLaunchpad is supposed to go against the 'test_dev' server, and if you invoke the TestLaunchpad constructor it does by default, but I didn't define overrides for all the helper methods. So TestLaunchpad.login_anonymously("application") doesn't go against test_dev: it goes against staging.

This is fine locally and on EC2, unless staging happens to be down. But code running on buildbot is prohibited from making external network requests, so the test fails with a cryptic httplib2 error.

I will do some more work on a more elegant solution, but simply changing the test should solve the problem. The login_anonymously() call is the only time we call one of the convenience methods of TestLaunchpad instead of using the constructor. (All the unit tests use NoNetworkLaunchpad.)

[j.c.sackett (jcsackett)]

This looks good to me.

review: Approve (code*)

[Gary Poster (gary)]

(I'm stepping in so we can get out of testfix mode faster.)

Thank you, looks good.

review: Approve

=== modified file 'src/launchpadlib/NEWS.txt'
--- src/launchpadlib/NEWS.txt	2011-01-04 18:54:10 +0000
+++ src/launchpadlib/NEWS.txt	2011-01-06 13:56:40 +0000
@@ -2,7 +2,12 @@
 NEWS for launchpadlib
 =====================
 
-1.9.0 (Unreleased)
+1.9.1 (2011-01-06)
+==================
+
+- Corrected a test failure.
+
+1.9.0 (2011-01-05)
 ==================
 
 - When an authorization token expires or becomes invalid, attempt to
 
=== modified file 'src/launchpadlib/__init__.py'
--- src/launchpadlib/__init__.py	2010-12-23 20:43:10 +0000
+++ src/launchpadlib/__init__.py	2011-01-06 13:56:40 +0000
@@ -14,4 +14,4 @@
 # You should have received a copy of the GNU Lesser General Public License
 # along with launchpadlib. If not, see <http://www.gnu.org/licenses/>.
 
-__version__ = '1.9.0'
+__version__ = '1.9.1'
 
=== modified file 'src/launchpadlib/docs/introduction.txt'
--- src/launchpadlib/docs/introduction.txt	2011-01-04 20:31:27 +0000
+++ src/launchpadlib/docs/introduction.txt	2011-01-06 13:56:40 +0000
@@ -190,7 +190,8 @@
 setting up a web service connection in one function call. All you have
 to provide is the consumer name.
 
-    >>> launchpad = Launchpad.login_anonymously('launchpad-library')
+    >>> launchpad = Launchpad.login_anonymously(
+    ...     'launchpad-library', service_root="test_dev")
     >>> sorted(launchpad.people)
     [...]