Merge lp:~leonardr/launchpad/get-field-uri into lp:launchpad

Proposed by Leonard Richardson
Status: Merged
Approved by: Robert Collins
Approved revision: 9493
Merge reported by: Leonard Richardson
Merged at revision: not available
Proposed branch: lp:~leonardr/launchpad/get-field-uri
Merge into: lp:launchpad
Diff against target: 71 lines
2 files modified
lib/canonical/launchpad/pagetests/packaging/xx-sourcepackage-packaging.txt (+14/-0)
lib/lp/soyuz/stories/soyuz/xx-sourcepackage-changelog.txt (+17/-0)
To merge this branch: bzr merge lp:~leonardr/launchpad/get-field-uri
Reviewer Review Type Date Requested Status
Paul Hummer (community) Approve
Review via email: mp+12344@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Leonard Richardson (leonardr) wrote :

This branch adds a new Javascript utility function, get_field_uri(). This function lets you get the URI to a field resource, given an entry resource and a field name.

In addition to unit tests of the new function, this branch adds two tests that make sure patch() works on a field resource.

This branch also gets rid of the client_parse_xml_entry method, which is not used within Launchpad and which was a bad idea in the first place.

You'll get one Javascript failure when running the Windmill tests, but that's a failure currently in trunk; it's not introduced by this branch.

Revision history for this message
Paul Hummer (rockstar) :
review: Approve
lp:~leonardr/launchpad/get-field-uri updated
9493. By Leonard Richardson

Merge from trunk.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'lib/canonical/launchpad/pagetests/packaging/xx-sourcepackage-packaging.txt'
--- lib/canonical/launchpad/pagetests/packaging/xx-sourcepackage-packaging.txt 2009-09-28 12:59:33 +0000
+++ lib/canonical/launchpad/pagetests/packaging/xx-sourcepackage-packaging.txt 2009-09-28 17:34:42 +0000
@@ -6,6 +6,7 @@
6 >>> user_browser.open(6 >>> user_browser.open(
7 ... "http://launchpad.dev/ubuntu/warty/+source/mozilla/+packaging")7 ... "http://launchpad.dev/ubuntu/warty/+source/mozilla/+packaging")
88
9<<<<<<< TREE
9 >>> print_location(user_browser.contents)10 >>> print_location(user_browser.contents)
10 Hierarchy: Ubuntu > 4.10 > ...mozilla... source package > Upstream links11 Hierarchy: Ubuntu > 4.10 > ...mozilla... source package > Upstream links
11 Tabs:12 Tabs:
@@ -17,6 +18,19 @@
17 * Answers - http://answers.launchpad.dev/ubuntu/warty/+source/mozilla18 * Answers - http://answers.launchpad.dev/ubuntu/warty/+source/mozilla
18 Main heading: Upstream links for ...mozilla... source package in Warty19 Main heading: Upstream links for ...mozilla... source package in Warty
1920
21=======
22 >>> print_location(user_browser.contents)
23 Hierarchy: Ubuntu > 4.10 > ...mozilla... source package > Upstream links
24 Tabs:
25 * Overview (selected) - http://launchpad.dev/ubuntu/warty/+source/mozilla
26 * Branches - http://code.launchpad.dev/ubuntu/warty/+source/mozilla
27 * Bugs - http://bugs.launchpad.dev/ubuntu/warty/+source/mozilla
28 * Blueprints - not linked
29 * Translations - http://translations.launchpad.dev/ubuntu/warty/+source/mozilla
30 * Answers - http://answers.launchpad.dev/ubuntu/warty/+source/mozilla
31 Main heading: Upstream links for mozilla in Ubuntu Warty
32
33>>>>>>> MERGE-SOURCE
20 >>> print extract_text(34 >>> print extract_text(
21 ... find_tags_by_class(user_browser.contents, 'informational')[0])35 ... find_tags_by_class(user_browser.contents, 'informational')[0])
22 Launchpad doesn&#8217;t know which project and series this package36 Launchpad doesn&#8217;t know which project and series this package
2337
=== modified file 'lib/lp/bugs/stories/distribution/xx-distribution-upstream-bug-report.txt'
=== modified file 'lib/lp/soyuz/stories/packaging/package-pages-navigation.txt'
=== modified file 'lib/lp/soyuz/stories/soyuz/xx-sourcepackage-changelog.txt'
--- lib/lp/soyuz/stories/soyuz/xx-sourcepackage-changelog.txt 2009-09-28 12:59:33 +0000
+++ lib/lp/soyuz/stories/soyuz/xx-sourcepackage-changelog.txt 2009-09-28 17:34:42 +0000
@@ -4,6 +4,7 @@
44
5 >>> user_browser.open(5 >>> user_browser.open(
6 ... "http://launchpad.dev/ubuntu/hoary/+source/pmount/+changelog")6 ... "http://launchpad.dev/ubuntu/hoary/+source/pmount/+changelog")
7<<<<<<< TREE
7 >>> print_location(user_browser.contents)8 >>> print_location(user_browser.contents)
8 Hierarchy: Ubuntu > 5.04 > ...pmount... source package > Change log9 Hierarchy: Ubuntu > 5.04 > ...pmount... source package > Change log
9 Tabs:10 Tabs:
@@ -18,6 +19,22 @@
1819
19 >>> print extract_text(20 >>> print extract_text(
20 ... find_tag_by_id(user_browser.contents, 'changelogs'))21 ... find_tag_by_id(user_browser.contents, 'changelogs'))
22=======
23 >>> print_location(user_browser.contents)
24 Hierarchy: Ubuntu > 5.04 > ...pmount... source package > Change log
25 Tabs:
26 * Overview (selected) - http://launchpad.dev/ubuntu/hoary/+source/pmount
27 * Branches - http://code.launchpad.dev/ubuntu/hoary/+source/pmount
28 * Bugs - http://bugs.launchpad.dev/ubuntu/hoary/+source/pmount
29 * Blueprints - not linked
30 * Translations - http://translations.launchpad.dev/ubuntu/hoary/+source/pmount
31 * Answers - http://answers.launchpad.dev/ubuntu/hoary/+source/pmount
32 Main heading: Change logs for pmount in Ubuntu Hoary
33
34
35 >>> print extract_text(
36 ... find_tag_by_id(user_browser.contents, 'changelogs'))
37>>>>>>> MERGE-SOURCE
21 This is a placeholder changelog for pmount 0.1-238 This is a placeholder changelog for pmount 0.1-2
22 pmount (0.1-1) hoary; urgency=low39 pmount (0.1-1) hoary; urgency=low
23 * Fix description (Malone #1)40 * Fix description (Malone #1)
2441
=== modified file 'lib/lp/translations/browser/configure.zcml'
=== modified file 'lib/lp/translations/model/translationimportqueue.py'