Code review comment for lp:~lenharo-h/duplicity/duplicity

Hi,

without looking into the code ede seems right.

Anyway, I made the following test:

duplicity --hidden-encrypt-key=12345678 --use-scp --ssh-backend pexpect
source scp://target//tmp/test
duplicity --use-scp --ssh-backend pexpect scp://target//tmp/test /tmp/scr

And it behaved like expected: asked for GPG passphrase and restored the
backup.
Did I do it right?

Best Regards,

Marcos A. Lenharo

On 22-11-2012 14:40, edso wrote:
> you totally loose me here :( sorry...
>
> the patch provided by Lenharo merely changes the way how gpg_interface.py encrypts the datastream locally. did you have a look at what is actually patched?
> http://bazaar.launchpad.net/~lenharo-h/duplicity/duplicity/revision/898
>
> it does in no way affect up/downloading in any backend as far as i can see. still you come across convincing, so i might miss something ;)
>
> ..ede
>
>
> On 22.11.2012 17:31, Kenneth Loafman wrote:
>> Look at the responses from sftp and scp. If the gpg response is expected,
>> check that the new option supplies that, otherwise we have to match on
>> additional strings.
>>
>> ...Ken
>>
>> On Thu, Nov 22, 2012 at 9:04 AM, edso <email address hidden> wrote:
>>
>>> just scanned
>>>
>>> http://bazaar.launchpad.net/~duplicity-team/duplicity/0.6-series/view/head:/duplicity/backends/_ssh_pexpect.py
>>> and can only see sftp and scp being used.
>>>
>>> what am i missing?
>>>
>>> ..ede
>>>
>>> On 22.11.2012 15:55, Kenneth Loafman wrote:
>>>> It uses pexpect to check the return strings. Sometimes that's from gpg.
>>>>
>>>> ...Ken
>>>>
>>>> On Thu, Nov 22, 2012 at 8:46 AM, edso <email address hidden> wrote:
>>>>
>>>>> how does a specific backend directly deal with gpg? isn't that the job
>>> of
>>>>> gpg_interface?
>>>>>
>>>>> ..ede
>>>>>
>>>>> On 22.11.2012 15:38, Kenneth Loafman wrote:
>>>>>> It will need to be modded, probably, since the responses from gpg are
>>>>>> different.
>>>>>>
>>>>>> On Thu, Nov 22, 2012 at 7:01 AM, Marcos Lenharo <email address hidden>
>>>>> wrote:
>>>>>>> No, but I can try it later.
>>>>>>> Why?
>>>>>>>
>>>>>>> Regards
>>>>>>> Em 22/11/2012 10:52, "Kenneth Loafman" <email address hidden>
>>> escreveu:
>>>>>>>> Has anyone tried restore with the _ssh_pexpect backend?
>>>>>>>> --
>>>>>>>>
>>>>> https://code.launchpad.net/~lenharo-h/duplicity/duplicity/+merge/135300
>>>>>>>> You are the owner of lp:~lenharo-h/duplicity/duplicity.
>>>>>>>>
>>>>>>> --
>>>>>>>
>>> https://code.launchpad.net/~lenharo-h/duplicity/duplicity/+merge/135300
>>>>>>> You are subscribed to branch lp:duplicity.
>>>>>>>
>>>>>
>>>>> --
>>>>> https://code.launchpad.net/~lenharo-h/duplicity/duplicity/+merge/135300
>>>>> You are subscribed to branch lp:duplicity.
>>>>>
>>> --
>>> https://code.launchpad.net/~lenharo-h/duplicity/duplicity/+merge/135300
>>> You are subscribed to branch lp:duplicity.
>>>