Merge lp:~lemonboy/switchboard-plug-keyboard/popover into lp:~elementary-pantheon/switchboard-plug-keyboard/trunk
Proposed by
The Lemon Man
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Danielle Foré | ||||
Approved revision: | 369 | ||||
Merged at revision: | 367 | ||||
Proposed branch: | lp:~lemonboy/switchboard-plug-keyboard/popover | ||||
Merge into: | lp:~elementary-pantheon/switchboard-plug-keyboard/trunk | ||||
Diff against target: |
52 lines (+5/-11) 2 files modified
src/Pages/Layout/add_layout.vala (+3/-7) src/Pages/Layout/display.vala (+2/-4) |
||||
To merge this branch: | bzr merge lp:~lemonboy/switchboard-plug-keyboard/popover | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Danielle Foré | Needs Fixing | ||
Review via email: mp+275784@code.launchpad.net |
Commit message
Use a Popover instead of a Dialog for AddLayout
To post a comment you must log in.
margins are a little fucky. Probably should change that grid.margin_start to just grid.margin so you get that 12px all the way around