Code review comment for lp:~le-chi-thu/lava-test/override-test-options

Revision history for this message
Paul Larson (pwlars) wrote :

> I updated the lava-test override-test-options. It is still the same syntax as
> before but the test options is an optional parameter.
>
> lava-test run [-h] [-q] [-Q] [-S] [-H] [--trusted-time] [-o FILE] [-A] test_id
> [test_options]

Indeed, it should be optional, however please see my previous comments. I think if we used something like --test-options "-a foo -b bar" instead, it would be better. Rational is explained in previous comment.

« Back to merge proposal