Merge lp:~le-chi-thu/lava-dispatcher/snowball_android_fix into lp:lava-dispatcher

Proposed by Le Chi Thu
Status: Merged
Approved by: Michael Hudson-Doyle
Approved revision: 190
Merged at revision: 195
Proposed branch: lp:~le-chi-thu/lava-dispatcher/snowball_android_fix
Merge into: lp:lava-dispatcher
Diff against target: 17 lines (+7/-1)
1 file modified
lava_dispatcher/default-config/lava-dispatcher/device-defaults.conf (+7/-1)
To merge this branch: bzr merge lp:~le-chi-thu/lava-dispatcher/snowball_android_fix
Reviewer Review Type Date Requested Status
Yongqin Liu Approve
Michael Hudson-Doyle (community) Approve
Zygmunt Krynicki (community) Approve
Review via email: mp+88792@code.launchpad.net

Description of the change

I forgot add new keys to default device file.

To post a comment you must log in.
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

+1

Please get another review though

review: Approve
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

+1

review: Approve
Revision history for this message
Spring Zhang (qzhang) wrote :

17 \ No newline at end of file
Can there be a newline? Is the warning message strange in Python? If yes, add the newline.

Revision history for this message
Yongqin Liu (liuyq0307) wrote :

thanks.
but I still doubt whether it is necessary that the source needs to be modified to make it more flexible.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'lava_dispatcher/default-config/lava-dispatcher/device-defaults.conf'
--- lava_dispatcher/default-config/lava-dispatcher/device-defaults.conf 2012-01-09 03:16:32 +0000
+++ lava_dispatcher/default-config/lava-dispatcher/device-defaults.conf 2012-01-16 23:28:31 +0000
@@ -88,4 +88,10 @@
88lmc_dev_arg = %(device_type)s88lmc_dev_arg = %(device_type)s
8989
90# The value to pass to qemu-system-arm's -M option.90# The value to pass to qemu-system-arm's -M option.
91qemu_machine_type = %(device_type)s
92\ No newline at end of file91\ No newline at end of file
92qemu_machine_type = %(device_type)s
93
94# This is used for snowball soft reset fix, since the reboot command is hanging.
95soft_boot_cmd =
96
97# This is for android build where the network is not up by default. 1 or 0
98enable_network_after_boot_android = 0
93\ No newline at end of file99\ No newline at end of file

Subscribers

People subscribed via source and target branches