Code review comment for lp:~le-chi-thu/lava-dispatcher/improve-logging

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

Hi, overall the change looks good. I share Paul's concerns about the configuration though -- in particular, it's not possible to 'stack' configurations as it is with the other configuration files we now have. This is in large part because logging.config basically sucks (if you could pass a ConfigParser instance to a function to configure the logging, there wouldn't be this problem).

Also, in my experience, people don't actually use fileConfig (I don't think I've worked on a single project that uses it in fact). I agree with Paul that we should start simple, and just allow a key 'log_level' in the general lava-dispatcher.conf file to set a log level, and when we want to customize other things, start from this base line.

« Back to merge proposal