Code review comment for lp:~le-chi-thu/lava-dispatcher/improve-logging-2

Revision history for this message
Le Chi Thu (le-chi-thu) wrote :

wait merging util I have updated according to the discussion below.

<zyga> ChiThu: so for that isuse: I was suggesting to use foo.set_logging_level("info") instead of 0 or 100 or whatever in between
<zyga> ChiThu: you can convert a string to an integer (for logging) using...
<zyga> ChiThu: try logging.getLevelName("INFO")
<zyga> ChiThu: then I was hoping that we actually validate the dispatcher job file
<zyga> ChiThu: a simple schema could check if the log level is in the valid set ("INFO", "DEBUG", etc)
<zyga> ChiThu: for doing that I could point you to json-schema-validator documentation
<zyga> ChiThu: and to json-document documentation (for better tutorial-like approach)
* antipov (~antipov@gateway/tor-sasl/antipov) has joined #linaro
<plars> zyga, ChiThu: Adding a schema for the dispatcher would also go a long way toward documenting the dispatcher
<ChiThu> zyga, yes, good idea about schema for dispatcher

« Back to merge proposal