Ubuntu
upstart package

Code review comment for lp:~ldgoodridge95/ubuntu/vivid/upstart/rm-libjson0

  1. Vivid (15.04)
  2. rm-libjson0
  3. Merge into vivid
Revision history for this message
Lance Goodridge (ldgoodridge95) wrote :

Hello Mr Trudel-Lapierre,

Thank you for reviewing my patch! I have removed the two libjson0-dev
dependencies per your suggestion and have a submitted a new merge
request.

Lance

On Mon, Feb 16, 2015 at 6:01 PM, Mathieu Trudel-Lapierre
<email address hidden> wrote:
> Review: Needs Fixing
>
> Looks fine, but the Build-Depends should probably be libjson-c-dev instead.
>
> Note; I'm looking at the upstart binary package and it looks like it probably doesn't need to Depends on libjson at all, and the upstart-bin package appears to already Depends on libjson-c2 via shlibs:Depends, so you might as well remove it from there too :)
>
> With these changes made I think things will be just fine to merge and upload.
> --
> https://code.launchpad.net/~ldgoodridge95/ubuntu/vivid/upstart/rm-libjson0/+merge/247526
> You are the owner of lp:~ldgoodridge95/ubuntu/vivid/upstart/rm-libjson0.

« Back to merge proposal