Merge lp:~lderan/ubuntu-bots/meeetingology-output into lp:~ubuntu-bots/ubuntu-bots/meetingology

Proposed by Thomas Molloy
Status: Superseded
Proposed branch: lp:~lderan/ubuntu-bots/meeetingology-output
Merge into: lp:~ubuntu-bots/ubuntu-bots/meetingology
Diff against target: 51 lines (+4/-5)
2 files modified
meeting.py (+2/-2)
writers.py (+2/-3)
To merge this branch: bzr merge lp:~lderan/ubuntu-bots/meeetingology-output
Reviewer Review Type Date Requested Status
Ubuntu IRC Bots Pending
Review via email: mp+205428@code.launchpad.net

This proposal supersedes a proposal from 2014-02-07.

This proposal has been superseded by a proposal from 2014-02-07.

Description of the change

Changed the layout for the vote output and set Jose to be the one notified when a meeting ends

To post a comment you must log in.
19. By Alan Bell

accepting merge

20. By Alan Bell

accepting fix

21. By Alan Bell

accpeting merge

22. By Thomas Molloy

DONE items for MoinMoin outputs now show up as DONE instead of ACTION

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'meeting.py'
--- meeting.py 2014-02-07 16:06:41 +0000
+++ meeting.py 2014-02-07 17:30:37 +0000
@@ -90,7 +90,7 @@
90 "\n"90 "\n"
91 "Minutes: %(urlBasename)s.moin.txt")91 "Minutes: %(urlBasename)s.moin.txt")
92 endMeetingNotification = ("Meeting in %(channel)s has just ended")92 endMeetingNotification = ("Meeting in %(channel)s has just ended")
93 endMeetingNotificationList = ["lderan"]93 endMeetingNotificationList = ["jose"]
94 94
95 #TODO: endMeetingMessage should get filenames from the writers95 #TODO: endMeetingMessage should get filenames from the writers
9696
@@ -397,7 +397,7 @@
397 """Remove the last item from the minutes."""397 """Remove the last item from the minutes."""
398 if not self.isChair(nick): return398 if not self.isChair(nick): return
399 if len(self.minutes) == 0: return399 if len(self.minutes) == 0: return
400 self.reply("Removing item from minutes: %s"%str(self.minutes[-1]))400 self.reply("Removing item from minutes: %s"%str(self.minutes[-1].itemtype))
401 del self.minutes[-1]401 del self.minutes[-1]
402 def do_restrictlogs(self, nick, **kwargs):402 def do_restrictlogs(self, nick, **kwargs):
403 """When saved, remove permissions from the files."""403 """When saved, remove permissions from the files."""
404404
=== modified file 'writers.py'
--- writers.py 2014-02-07 16:13:27 +0000
+++ writers.py 2014-02-07 17:30:37 +0000
@@ -1218,7 +1218,7 @@
1218 if len(M.votes) > 0:1218 if len(M.votes) > 0:
1219 for m in M.votes:1219 for m in M.votes:
1220 # differentiate denied votes somehow, strikethrough perhaps?1220 # differentiate denied votes somehow, strikethrough perhaps?
1221 Votes.append(" * [[%(fullLogsFullURL)s#"+str(M.votes[m][3])+" "+m+"]]")1221 Votes.insert(0," * [[%(fullLogsFullURL)s#"+str(M.votes[m][3])+" "+m+"]]"))
1222 motion = "Deadlock"1222 motion = "Deadlock"
1223 if(M.votes[m][0] > M.votes[m][1]):1223 if(M.votes[m][0] > M.votes[m][1]):
1224 motion = "Motion carried"1224 motion = "Motion carried"
@@ -1227,7 +1227,7 @@
1227 Votes.insert(0," * " + motion + " (For/Against/Abstained "+str(M.votes[m][0])+"/"+str(M.votes[m][2])+"/"+str(M.votes[m][1]) + ")")1227 Votes.insert(0," * " + motion + " (For/Against/Abstained "+str(M.votes[m][0])+"/"+str(M.votes[m][2])+"/"+str(M.votes[m][1]) + ")")
1228 if len(M.publicVoters[m]) > 0:1228 if len(M.publicVoters[m]) > 0:
1229 publicVoters = ', '.join(set(M.publicVoters[m]))1229 publicVoters = ', '.join(set(M.publicVoters[m]))
1230 Votes.append(" * Voters " + publicVoters)1230 Votes.insert(0, " * Voters " + publicVoters)
1231 Votes = "\n".join(Votes) 1231 Votes = "\n".join(Votes)
1232 return Votes1232 return Votes
12331233
@@ -1337,7 +1337,6 @@
1337 body.append(self.body_start%repl)1337 body.append(self.body_start%repl)
1338 body.append(self.meetingItems())1338 body.append(self.meetingItems())
1339 body.append(self.votes()%repl)1339 body.append(self.votes()%repl)
1340 body.append(self.actionItems())
1341 body.append(self.actionItemsPerson())1340 body.append(self.actionItemsPerson())
1342 body.append(self.doneItems())1341 body.append(self.doneItems())
1343 body.append(self.peoplePresent())1342 body.append(self.peoplePresent())

Subscribers

People subscribed via source and target branches