Code review comment for lp:~ldeo-magma/dolfin/devfixes

Revision history for this message
Johan Hake (johan-hake) wrote :

On Friday October 28 2011 12:56:26 Garth Wells wrote:
> Review: Needs Fixing
>
> Looks good at first glance. Now for the unpleasant side: could add some
> unit tests?

If this is about adding the operator= to MeshValueCollection you might want to
look at how we have mapped this to Python for some of the la classes. There we
rename the operator= to assign so one can do:

  mesh.domains().markers(0).assign(mesh_function)

This is needed as there are no such thing as a operator= in Python

Disclaimer: I have not looked at the code yet, and you might already have done
this :P

Johan

« Back to merge proposal