Code review comment for ~lcvcode/charm-nagios:LP1939068-duplicates

Revision history for this message
Paul Goins (vultaire) wrote :

Sorry for the thrash here.

I've tried to deploy this on serverstack, with multiple related models and nrpe related to apps on top-level nodes and to LXDs, and I'm seeing these issues:

* For a hostname collision at the parent level, I do see that I get records for both hosts; one has a suffix appended. However, the host group names are not consistent. For example, host juju-host-0 is associated with host group juju-host, while host juju-host-0-[1] is associated with host group juju-host-0. This is potentially confusing, especially since the latter host group matches the former host which isn't even part of that host group.

* If I have an app of the same name installed onto containers in two different models, they collide and I only see one in nagios.

This is with the following deployment: https://pastebin.ubuntu.com/p/26hb2ptYHt/
(Summary: nagios on one model, plus 2 other models, each with cs:ubuntu deployed as host and LXD, with nrpe related to each.)

This was done on serverstack (i.e. OpenStack), not a MAAS or LXD based controller.

I'm not sure what exactly in the code needs fixing yet, but I'm -1'ing for now.

review: Needs Fixing

« Back to merge proposal