During a 1:1, I remembered: I had concerns over how the status was being set here, and whether it might be being clobbered elsewhere in the charm. I very much support this MR as a stopgap to avoid having services clobber the wrong host in Nagios, especially if we have a message indicating that duplicate hostnames have been found, as that may guide toward reconfiguring the nagios_host_context to something more appropriate to avoid the collisions.
Temporarily marking as abstain; intending to check this tomorrow.
During a 1:1, I remembered: I had concerns over how the status was being set here, and whether it might be being clobbered elsewhere in the charm. I very much support this MR as a stopgap to avoid having services clobber the wrong host in Nagios, especially if we have a message indicating that duplicate hostnames have been found, as that may guide toward reconfiguring the nagios_host_context to something more appropriate to avoid the collisions.
Temporarily marking as abstain; intending to check this tomorrow.