Code review comment for ~lcvcode/charm-nagios:LP1939068-duplicates

Revision history for this message
Paul Goins (vultaire) wrote :

I'm +1 for the change as it fills a gap in the case that nagios_host_context is specified with the same value on multiple models.

However, I believe it is superior to use distinct nagios_host_contexts for each model, and to include something in the host context to identify the model from which the record came.

For example, if you have keystone deployed to both an OpenStack and K8s model; and if hostnames are autogenerated as e.g. keystone-0, keystone-1, etc.; then including the model name in the host context would generate hostnames like e.g. <prefix>-openstack-keystone-0, <prefix>-kubernetes-keystone-0. That'd give more semantic meaning to the hostnames and would have less problems re: event history in cases things get added/removed.

review: Approve

« Back to merge proposal