Merge lp:~lbssousa/lightdm-gtk-greeter/2.0-fix-timed-autologin into lp:~lightdm-gtk-greeter-team/lightdm-gtk-greeter/2.0

Proposed by Laércio de Sousa
Status: Merged
Merge reported by: Sean Davis
Merged at revision: not available
Proposed branch: lp:~lbssousa/lightdm-gtk-greeter/2.0-fix-timed-autologin
Merge into: lp:~lightdm-gtk-greeter-team/lightdm-gtk-greeter/2.0
Diff against target: 45 lines (+28/-1)
1 file modified
src/lightdm-gtk-greeter.c (+28/-1)
To merge this branch: bzr merge lp:~lbssousa/lightdm-gtk-greeter/2.0-fix-timed-autologin
Reviewer Review Type Date Requested Status
Sean Davis Pending
Review via email: mp+257542@code.launchpad.net

Description of the change

This patch fixes a timed autologin issue. Currently, when autologin timeout expires, and configured autologin user is already selected in user list, lightdm-gtk-greeter's authentication_complete_cb() doesn't start user session unless user clicks on login button.

To post a comment you must log in.
324. By Laércio de Sousa

Avoid triggering autologin if user locks screen with light-locker.

325. By Laércio de Sousa

Add missing argument in previous commit.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/lightdm-gtk-greeter.c'
--- src/lightdm-gtk-greeter.c 2015-01-26 14:41:10 +0000
+++ src/lightdm-gtk-greeter.c 2015-05-13 13:13:58 +0000
@@ -2305,6 +2305,33 @@
2305}2305}
23062306
2307static void2307static void
2308timed_autologin_cb (LightDMGreeter *greeter)
2309{
2310 /* Don't trigger autologin if user locks screen with light-locker (thanks to Andrew P.). */
2311 if (!lightdm_greeter_get_lock_hint (greeter))
2312 {
2313 if (lightdm_greeter_get_is_authenticated (greeter))
2314 {
2315 /* Configured autologin user may be already selected in user list. */
2316 if (lightdm_greeter_get_authentication_user (greeter))
2317 /* Selected user matches configured autologin-user option. */
2318 start_session ();
2319 else if (lightdm_greeter_get_autologin_guest_hint (greeter))
2320 /* "Guest session" is selected and autologin-guest is enabled. */
2321 start_session ();
2322 else if (lightdm_greeter_get_autologin_user_hint (greeter))
2323 {
2324 /* "Guest session" is selected, but autologin-user is configured. */
2325 start_authentication (lightdm_greeter_get_autologin_user_hint (greeter));
2326 prompted = TRUE;
2327 }
2328 }
2329 else
2330 lightdm_greeter_authenticate_autologin (greeter);
2331 }
2332}
2333
2334static void
2308authentication_complete_cb (LightDMGreeter *greeter)2335authentication_complete_cb (LightDMGreeter *greeter)
2309{2336{
2310 prompt_active = FALSE;2337 prompt_active = FALSE;
@@ -2678,7 +2705,7 @@
2678 g_signal_connect (greeter, "show-prompt", G_CALLBACK (show_prompt_cb), NULL);2705 g_signal_connect (greeter, "show-prompt", G_CALLBACK (show_prompt_cb), NULL);
2679 g_signal_connect (greeter, "show-message", G_CALLBACK (show_message_cb), NULL);2706 g_signal_connect (greeter, "show-message", G_CALLBACK (show_message_cb), NULL);
2680 g_signal_connect (greeter, "authentication-complete", G_CALLBACK (authentication_complete_cb), NULL);2707 g_signal_connect (greeter, "authentication-complete", G_CALLBACK (authentication_complete_cb), NULL);
2681 g_signal_connect (greeter, "autologin-timer-expired", G_CALLBACK (lightdm_greeter_authenticate_autologin), NULL);2708 g_signal_connect (greeter, "autologin-timer-expired", G_CALLBACK (timed_autologin_cb), NULL);
2682 if (!lightdm_greeter_connect_sync (greeter, NULL))2709 if (!lightdm_greeter_connect_sync (greeter, NULL))
2683 return EXIT_FAILURE;2710 return EXIT_FAILURE;
26842711

Subscribers

People subscribed via source and target branches