Merge lp:~lbssousa/lightdm-gtk-greeter/2.0-fix-timed-autologin into lp:~lightdm-gtk-greeter-team/lightdm-gtk-greeter/2.0

Proposed by Laércio de Sousa
Status: Merged
Merge reported by: Sean Davis
Merged at revision: not available
Proposed branch: lp:~lbssousa/lightdm-gtk-greeter/2.0-fix-timed-autologin
Merge into: lp:~lightdm-gtk-greeter-team/lightdm-gtk-greeter/2.0
Diff against target: 45 lines (+28/-1)
1 file modified
src/lightdm-gtk-greeter.c (+28/-1)
To merge this branch: bzr merge lp:~lbssousa/lightdm-gtk-greeter/2.0-fix-timed-autologin
Reviewer Review Type Date Requested Status
Sean Davis Pending
Review via email: mp+257542@code.launchpad.net

Description of the change

This patch fixes a timed autologin issue. Currently, when autologin timeout expires, and configured autologin user is already selected in user list, lightdm-gtk-greeter's authentication_complete_cb() doesn't start user session unless user clicks on login button.

To post a comment you must log in.
324. By Laércio de Sousa

Avoid triggering autologin if user locks screen with light-locker.

325. By Laércio de Sousa

Add missing argument in previous commit.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/lightdm-gtk-greeter.c'
2--- src/lightdm-gtk-greeter.c 2015-01-26 14:41:10 +0000
3+++ src/lightdm-gtk-greeter.c 2015-05-13 13:13:58 +0000
4@@ -2305,6 +2305,33 @@
5 }
6
7 static void
8+timed_autologin_cb (LightDMGreeter *greeter)
9+{
10+ /* Don't trigger autologin if user locks screen with light-locker (thanks to Andrew P.). */
11+ if (!lightdm_greeter_get_lock_hint (greeter))
12+ {
13+ if (lightdm_greeter_get_is_authenticated (greeter))
14+ {
15+ /* Configured autologin user may be already selected in user list. */
16+ if (lightdm_greeter_get_authentication_user (greeter))
17+ /* Selected user matches configured autologin-user option. */
18+ start_session ();
19+ else if (lightdm_greeter_get_autologin_guest_hint (greeter))
20+ /* "Guest session" is selected and autologin-guest is enabled. */
21+ start_session ();
22+ else if (lightdm_greeter_get_autologin_user_hint (greeter))
23+ {
24+ /* "Guest session" is selected, but autologin-user is configured. */
25+ start_authentication (lightdm_greeter_get_autologin_user_hint (greeter));
26+ prompted = TRUE;
27+ }
28+ }
29+ else
30+ lightdm_greeter_authenticate_autologin (greeter);
31+ }
32+}
33+
34+static void
35 authentication_complete_cb (LightDMGreeter *greeter)
36 {
37 prompt_active = FALSE;
38@@ -2678,7 +2705,7 @@
39 g_signal_connect (greeter, "show-prompt", G_CALLBACK (show_prompt_cb), NULL);
40 g_signal_connect (greeter, "show-message", G_CALLBACK (show_message_cb), NULL);
41 g_signal_connect (greeter, "authentication-complete", G_CALLBACK (authentication_complete_cb), NULL);
42- g_signal_connect (greeter, "autologin-timer-expired", G_CALLBACK (lightdm_greeter_authenticate_autologin), NULL);
43+ g_signal_connect (greeter, "autologin-timer-expired", G_CALLBACK (timed_autologin_cb), NULL);
44 if (!lightdm_greeter_connect_sync (greeter, NULL))
45 return EXIT_FAILURE;
46

Subscribers

People subscribed via source and target branches