Code review comment for lp:~lazypower/charms/trusty/mariadb/enterprise-upgrade-option

Revision history for this message
Daniel Bartholomew (dbart) wrote :

This is looking really good. But there are a couple of things need to be fixed for it to be ready for prime time.

First off, the MariaDB Enterprise signing key needs to be imported so that installing or upgrading to MariaDB Enterprise works. The gpg ID of the enterprise key is: D324876EBE6A595F

Next, the MariaDB community repository needs to be disabled or removed so that it doesn't conflict with the Enterprise repository.

Lastly, MariaDB needs to be uninstalled and reinstalled to replace community with Enterprise with commands similar to the following:

  sudo apt-get remove mariadb-common mariadb-client

  sudo apt-get install mariadb-server mariadb-client

Looking at the above two commands, it would be much better if the MariaDB Enterprise packages replaced the MariaDB community packages, and I think if they were at the same version number then they would, the issue is that the Enterprise packages, which go through extra tweaks and development above and beyond the community version usually therefore are a version behind the community packages, so I don't know if there is an easy way to do it. What I don't want to have happen is for the removal of MariaDB community to also trigger the removal of some other package that is depending on MariaDB. Any ideas?

Thanks!

review: Needs Fixing

« Back to merge proposal