Juju Charms Collection
kibana package

Code review comment for lp:~lazypower/charms/trusty/kibana/add-dashboard-loader-action

  1. Trusty Tahr (14.04)
  2. add-dashboard-loader-action
  3. Merge into trunk
Revision history for this message
Charles Butler (lazypower) wrote :

cory, thanks for the detailed review.

I can address the final comment with a follow up comment - no. There's a virtual host setup to proxy connections over to the elastic search host (this is important, otherwise you have to juju expose elastic search. Kibana works client-side, and directly queries elastic search over a javascript based client side lib.

So good catch, but not a concern in this context.

« Back to merge proposal