Juju Charms Collection
kibana package

Code review comment for lp:~lazypower/charms/trusty/kibana/add-dashboard-loader-action

  1. Trusty Tahr (14.04)
  2. add-dashboard-loader-action
  3. Merge into trunk
Revision history for this message
Konstantinos Tsakalozos (kos.tsakalozos) wrote :

Hi Charles,

Thank you for your work here. I managed to test the patch and it seems to work. I can see the dashboards but I haven't tested all the available functionality, yet. I am in the process of reviewing the related charms.

An issue that needs your attention is the flakyness of 11-scale-elastic.py.
There might not be enough time for the record insertion to propagate. Also this test will succeed only the first time and fail in any subsequent runs. An idea would be to start the test by reading the results count then proceed with the insertion and finally do a continuous poll of the result with a time out. Understandably this flakyness may not be due to your patch but it is there.

Thank you for your time and effort.

review: Needs Fixing

« Back to merge proposal