Merge lp:~lazypower/charms/trusty/etcd/bump-to-seven into lp:charms/trusty/etcd

Proposed by Charles Butler
Status: Rejected
Rejected by: Charles Butler
Proposed branch: lp:~lazypower/charms/trusty/etcd/bump-to-seven
Merge into: lp:charms/trusty/etcd
Diff against target: 33 lines (+11/-0) (has conflicts)
2 files modified
hooks/client-relation-changed (+6/-0)
hooks/client-relation-joined (+5/-0)
Text conflict in hooks/client-relation-changed
Text conflict in hooks/client-relation-joined
To merge this branch: bzr merge lp:~lazypower/charms/trusty/etcd/bump-to-seven
Reviewer Review Type Date Requested Status
charmers Pending
Review via email: mp+286565@code.launchpad.net

Description of the change

Missed a /g on the original sed that landed in etcd-6

This patches that behavior

To post a comment you must log in.

Unmerged revisions

21. By Charles Butler

Patch rev-6 to replace all instances of 7001 with 4001

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'hooks/client-relation-changed'
--- hooks/client-relation-changed 2016-02-17 21:41:50 +0000
+++ hooks/client-relation-changed 2016-02-18 20:25:56 +0000
@@ -4,7 +4,13 @@
4leader=$(is-leader)4leader=$(is-leader)
5if [[ $leader == True ]]; then5if [[ $leader == True ]]; then
6 connection_string=$(chlp unitdata get etcd.connection_string)6 connection_string=$(chlp unitdata get etcd.connection_string)
7<<<<<<< TREE
7 patched_string=$(echo $connection_string | sed "s/7001/4001/")8 patched_string=$(echo $connection_string | sed "s/7001/4001/")
9=======
10 # This is a temporary fix prior to interface:etcd supplanting this charm
11 patched_string=$(echo $connection_string | sed 's/7001/4001/g')
12
13>>>>>>> MERGE-SOURCE
8 # maintain some backwords compatibility with the existing interface until it14 # maintain some backwords compatibility with the existing interface until it
9 # is phased out w/ the layer rewrite.15 # is phased out w/ the layer rewrite.
10 relation-set connection_string=$patched_string port=4001 public_address=`unit-get public-address`16 relation-set connection_string=$patched_string port=4001 public_address=`unit-get public-address`
1117
=== modified file 'hooks/client-relation-joined'
--- hooks/client-relation-joined 2016-02-17 21:41:50 +0000
+++ hooks/client-relation-joined 2016-02-18 20:25:56 +0000
@@ -6,6 +6,11 @@
6 connection_string=$(chlp unitdata get etcd.connection_string)6 connection_string=$(chlp unitdata get etcd.connection_string)
7 patched_string=$(echo $connection_string | sed "s/7001/4001/")7 patched_string=$(echo $connection_string | sed "s/7001/4001/")
8 # maintain some backwords compatibility with the existing interface until it8 # maintain some backwords compatibility with the existing interface until it
9<<<<<<< TREE
9 # is phased out w/ the layer rewrite.10 # is phased out w/ the layer rewrite.
10 relation-set connection_string=$patched_string port=4001 public_address=`unit-get public-address`11 relation-set connection_string=$patched_string port=4001 public_address=`unit-get public-address`
12=======
13 patched_string=$(echo $connection_string | sed 's/7001/4001/g')
14 relation-set connection_string=$patched_string port=4001 public_address=`unit-get public-address`
15>>>>>>> MERGE-SOURCE
11fi16fi

Subscribers

People subscribed via source and target branches

to all changes: