Juju Charms Collection
docker package

Code review comment for lp:~lazypower/charms/trusty/docker/trunk

  1. Trusty Tahr (14.04)
  2. trunk
  3. Merge into trunk
Revision history for this message
Cory Johns (johnsca) wrote :

I agree with Ben's assessment that DockerOpts needs tests (and documentation). There are also still some missing hooks, including a newly added relation missing a hook. I created issues on GitHub for these:

https://github.com/chuckbutler/docker-charm/issues/54
https://github.com/chuckbutler/docker-charm/issues/53

I also updated an existing issue for the missing start hook because I still think it's a significant issue:

https://github.com/chuckbutler/docker-charm/issues/21

Along with Ben's comment about the install hook, and Whit's comment in a Hangouts session we had, I think it would be worth replacing the install hook with just bash (a la setup.sh) and eschew Python there completely:

https://github.com/chuckbutler/docker-charm/issues/55

« Back to merge proposal