Merge lp:~lazypower/charm-tools/refactor-readme-lint into lp:charm-tools/1.6
Proposed by
Charles Butler
Status: | Merged |
---|---|
Merged at revision: | 358 |
Proposed branch: | lp:~lazypower/charm-tools/refactor-readme-lint |
Merge into: | lp:charm-tools/1.6 |
Diff against target: |
81 lines (+8/-8) 6 files modified
charmtools/charms.py (+3/-3) tests_functional/proof/expected/broken-maintainer (+1/-1) tests_functional/proof/expected/icon-template (+1/-1) tests_functional/proof/expected/missing-maintainer (+1/-1) tests_functional/proof/expected/test (+1/-1) tests_functional/proof/expected/unknown-metadata (+1/-1) |
To merge this branch: | bzr merge lp:~lazypower/charm-tools/refactor-readme-lint |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Tim Van Steenburgh (community) | Approve | ||
Review via email: mp+266784@code.launchpad.net |
Description of the change
Refactored the README.ex lint to spit out the matched line contents, vs the line number.
When linting a charm, matched README.ex boilerplate line number isn't terribly helpful, but knowing what content we have matched really helps to narrow down what has matched. This may not be the right approach but it certainly starts the conversation.
To post a comment you must log in.
`make check` fails now, e.g.:
--- tests_functiona l/proof/ expected/ unknown- metadata 2015-08-25 14:56:08.755392000 -0400 l/proof/ results/ unknown- metadata 2015-08-27 15:24:25.685029478 -0400
+++ tests_functiona
@@ -2,7 +2,7 @@
I: metadata name (test) must match directory name (unknown-metadata) exactly for local deployment.
W: no copyright file
W: Includes template README.ex file
-W: README.ex includes line 1 of boilerplate README.ex
+W: Boilerplate readmeidentified in README.ex: Describe the intended usage of this charm and anything unique about how this charm relates to others here.
E: template interface names should be changed: interface-name
E: Unknown relation field in relation relation-name - (baz)
E: template relations should be renamed to fit charm: relation-name