Code review comment for lp:~laurynas-biveinis/percona-xtrabackup/xb-changed-page-bitmap

> - it would be nice to have an option to force the old .delta
> calculation method even if bitmaps are available; something like
> --incremental-force-scan?

Yes.

> - there's no need to append ';' to the end of a query in
> mysql_query()

Ack

> - the optimization attempt to wrap multiple INSERT statements for
> incremental tests into BEGIN/COMMIT does not work, as we disconnect
> between mysql client invokations; it should be smth like the
> following:
> : (echo "BEGIN;"; echo "..."; echo "COMMIT;") | $MYSQL $MYSQL_ARGS ...

Right, I forgot that it's all separate connections, thus separate transactions. I had some sort of persistent connection setup in progress at bug 1119451, comments #2 and #3. I think here we can just go with one statement transactions and optimize later as needed (bug 1119451 stuff is incomplete).

> - would updating docs in the same MP be a stretch? Just trying to
> avoid the communication overhead when docs are updated by Hrvoje,
> and the required docs updates seem to be minor

Will review, should be feasible.

> Please let me know if addressing the above would take more than a day. We can
> then merge the current MP as is, and address the remaining stuff later.

It should take less than a day, and I will work on this today (maybe tomorrow morning will be needed to wait for Jenkins run etc).