Code review comment for lp:~laurynas-biveinis/percona-xtrabackup/xb-changed-page-bitmap

Revision history for this message
Alexey Kopytov (akopytov) wrote :

Laurynas,

There's no time for a detailed review, but:

   - it would be nice to have an option to force the old .delta
     calculation method even if bitmaps are available; something like
     --incremental-force-scan?
   - there's no need to append ';' to the end of a query in
     mysql_query()
   - the optimization attempt to wrap multiple INSERT statements for
     incremental tests into BEGIN/COMMIT does not work, as we disconnect
     between mysql client invokations; it should be smth like the
     following:
: (echo "BEGIN;"; echo "..."; echo "COMMIT;") | $MYSQL $MYSQL_ARGS ...
   - would updating docs in the same MP be a stretch? Just trying to
     avoid the communication overhead when docs are updated by Hrvoje,
     and the required docs updates seem to be minor

Please let me know if addressing the above would take more than a day. We can then merge the current MP as is, and address the remaining stuff later.

review: Needs Fixing

« Back to merge proposal