Code review comment for lp:~laurynas-biveinis/percona-xtrabackup/bug1098498-1132763-2.0
Revision history for this message
| Alexey Kopytov (akopytov) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
The partial datadir wipe in in_part is wrong, it should remove it fully and restore from the backup directory. You can fix it in the same MP.
The second link for bug722638.sh failure is Galera-specific, and has nothing to do with the server shutdown. Bug #1098501.
The point is, until XtraBackup supports offline backups, it should never rely on the datadir state after stopping the server. If that's not true, those are test suite bugs and should be fixed together with this change.