Code review comment for lp:~laurynas-biveinis/percona-server/xtradb-thread-nice

Revision history for this message
Laurynas Biveinis (laurynas-biveinis) wrote :

Sergei -

> There are also lines in test cases which are commented out.
> diff lines 165-168,177,178,217-220,229,230,269-272,281,282,321-324,333,334

Diff line 164 explained this: these are the valid values for the variable, but the test would not necessarily succeed as it needs ulimit setup. Thus leave them in the test to show the legal values, but do not attempt to execute them.

« Back to merge proposal