Code review comment for lp:~laurynas-biveinis/percona-server/xtradb-thread-nice
Revision history for this message
| Sergei Glushchenko (sergei.glushchenko) wrote | # |
review:
Needs Fixing
(g2)
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
Hi Laurynas,
I noted a lot of OS checks in tests, would be nice to have file have_linux.inc and use it. Also "Linux" (double quotes) is not compatible with MySQL ansi mode, not sure if it is important. Introduction of have_linux will probably not save a lot of code lines, but will save a bit of time for those who need to implement that check in future. One can easily find have_linux.inc and use it instead of digging the actual way how check OS.
Otherwise looks good.