Code review comment for lp:~laurynas-biveinis/percona-server/merge-5.5.39

> - what’s wrong with Oracle’s fix for bug 1277351 /
> http://bugs.mysql.com/bug.php?id=71603

Nothing is wrong with that fix, it's just that this bug is part of the MDEV-382 bug batch. The other fixes of MDEV-382 are not reverted in 5.5 at the moment, and in general it is easiest to revert the whole batch at the same time, separate from other work such as merges. But this particular bug fix happens to be local enough to be reverted with the merge, if you want me to.

> - I don’t see any revisions with fixes for
> http://bugs.mysql.com/bug.php?id=72665 (what is it anyway?),
> http://bugs.mysql.com/bug.php?id=71585 (bug 1278072), and
> http://bugs.mysql.com/bug.php?id=71858 (bug 1286186)?

72665 fix is lp:mysql-server/5.5 commit 4666. The other two have been fixed in a release before, 5.5.38, but I missed the fact at the time. I don't have their revisions handy, can dig up if needed.

72665 is

CREATE TABLE t1(c42 tinyblob not null, c45 TEXT, unique(c42 (255)), unique(c45 (255))) ENGINE=innodb;

ALTER TABLE t1 MODIFY c45 SET('') NOT NULL;

DROP TABLE t1;

140516 9:19:16 InnoDB: Assertion failure in thread 4608106496 in file ha_innodb.cc line 7215
InnoDB: Failing assertion: primary_key_no == -1 || primary_key_no == 0

> - I don’t see any changes to errmsg-utf8.txt, nor any changes in .result
> files that might be relevant to “re-record affected testcases”?

I mixed up the commit messages, this bit should have gone to the 5.6.20 merge one.

« Back to merge proposal