Code review comment for lp:~laurynas-biveinis/percona-server/merge-5.1.72

Revision history for this message
Alexey Kopytov (akopytov) wrote :

  - spurious change in buf_page_get_gen():

--- Percona-Server/storage/innodb_plugin/buf/buf0buf.c 2013-08-16 13:16:17 +0000
+++ Percona-Server/storage/innodb_plugin/buf/buf0buf.c 2013-10-11 11:17:18 +0000
@@ -1843,7 +1843,7 @@
   rw_lock_s_unlock(&page_hash_latch);
  }

-loop2:
+ loop2:
  if (block == NULL) {
   /* Page not in buf_pool: needs to be read from file */

  - now that ‘loop2’ is only used by “UNIV_DEBUG || UNIV_IBUF_DEBUG”
    code, it should be wrapped into appropriate #ifdef to avoid warnings.

review: Needs Fixing

« Back to merge proposal