Merge lp:~laurynas-biveinis/percona-server/bug905711 into lp:percona-server/5.1
Proposed by
Laurynas Biveinis
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Alexey Kopytov | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 413 | ||||
Proposed branch: | lp:~laurynas-biveinis/percona-server/bug905711 | ||||
Merge into: | lp:percona-server/5.1 | ||||
Prerequisite: | lp:~laurynas-biveinis/percona-server/bug902467 | ||||
Diff against target: |
51 lines (+16/-2) 3 files modified
Percona-Server/mysql-test/r/bug63793.result (+5/-0) Percona-Server/mysql-test/t/bug63793.test (+9/-0) Percona-Server/sql/sql_select.cc (+2/-2) |
||||
To merge this branch: | bzr merge lp:~laurynas-biveinis/percona-server/bug905711 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Alexey Kopytov (community) | Approve | ||
Review via email: mp+86316@code.launchpad.net |
Description of the change
Fix bug 905711: Crash in DTCollation:
63793.
The cause and the fix are the same as for upstream 53236 (except that
that testcase does not trigger the crash): don't call member functions
with this == NULL in sql_select.
clone_item() returns NULL, then there is no need to set the
collation.
Add new testcase bug63793.
To post a comment you must log in.
Looks good to me except that if I saw the 'backport' word somewhere in the revision/MP comments, figuring out what the patch is would be a no-op. But that's a minor thing, feel free to ignore.