Code review comment for lp:~laurynas-biveinis/percona-server/bug1191580-1191589-5.1

Vlad Lesin (vlad-lesin) wrote :

This change

@@ -4029,11 +4030,7 @@
                if (cond && !cond->val_int())

- if (schema_table_store_record(thd, table))
- {
- log_online_bitmap_iterator_release(&i);
- }
+ OK(schema_table_store_record(thd, table));


should be reverted because if schema_table_store_record() fails (for example there is no free space for MyISAM temp table) there will be memory leak as heap memory allocation was done during initialization of "i" iterator.

review: Needs Fixing (g2)

« Back to merge proposal