This change
@@ -4029,11 +4030,7 @@ if (cond && !cond->val_int()) continue;
- if (schema_table_store_record(thd, table)) - { - log_online_bitmap_iterator_release(&i); - DBUG_RETURN(1); - } + OK(schema_table_store_record(thd, table));
++output_rows_num; }
should be reverted because if schema_table_store_record() fails (for example there is no free space for MyISAM temp table) there will be memory leak as heap memory allocation was done during initialization of "i" iterator.
« Back to merge proposal
This change
@@ -4029,11 +4030,7 @@
continue;
if (cond && !cond->val_int())
- if (schema_ table_store_ record( thd, table)) bitmap_ iterator_ release( &i); table_store_ record( thd, table));
- {
- log_online_
- DBUG_RETURN(1);
- }
+ OK(schema_
}
should be reverted because if schema_ table_store_ record( ) fails (for example there is no free space for MyISAM temp table) there will be memory leak as heap memory allocation was done during initialization of "i" iterator.