Percona Server moved to https://jira.percona.com/projects/PS

Code review comment for lp:~laurynas-biveinis/percona-server/ahi-partitions-5.6-5.6

  1. ahi-partitions-5.6-5.6
  2. Merge into 5.6
Revision history for this message
Laurynas Biveinis (laurynas-biveinis) wrote :

> Why buf_pool_mutex_enter_all() / buf_pool_mutex_exit_all() calls are
> being removed from btr_search_validate[_one_table]()?

A mistake, mix-up with the buffer pool mutex split patch.

> > +#include "btr0types.h"
>
> Why new #includes in mtr0log.ic, que0que.h and read0read.h, trx0roll.h,
> trx0trx.cc, ut0ut.cc and os0file.cc?

It's because trx0trx.ic needs btr stuff in trx_search_latch_reserve_if_needed(), and with these includes I broke the circular dependencies.

« Back to merge proposal