Code review comment for lp:~laurynas-biveinis/percona-server/26611-bug1059738-5.1

Revision history for this message
Alexey Kopytov (akopytov) wrote :

Laurynas,

- why did you remove "ut_ad(mtr->trx->fake_changes);" from the original patch? Looks like a good idea to me.

- what's the purpose of unfixing the sibling pages from the buffer? How about adding a comment?

- it must be "} else {" rather than "}<newline>else {"

review: Needs Fixing

« Back to merge proposal